From: Mike S. <log...@pe...> - 2003-06-02 01:46:29
|
On Fri, 30 May 2003, Jim Cromie wrote: > Yeah, the optimizer part took some time to Grok. > I hope that the code and the comments will take you thru the hard parts, > let me know if otherwize. Jim, nice work! Here's a couple of item I stumbled across, in the order I encountered them: * You might want to explain what 'static method style' is. * You write: "Log::Log4perl provides easy_init(), which achieves some simplification of categories, but you are still faced with creating them once" -- but this function doesn't really do anything for categories. The stealth logger feature included via 'use Log::Log4perl qw(:easy);' is probably what you're referring to -- although you don't have to 'create' categories, it just uses the class names. * As mentioned before, I like the coverage feature a lot. What's the "unseen log", though, and how does it work? * Looks like in # for example, debug Frob.pm, but only info on Frob::nicate() log4perl.category.Frob = DEBUG log4perl.category.Frob.nicate.debug = INFO -- there's no appender, would be informative to see what the recommended way of defining them is (and think of messages "bubbling up" :). * I didn't understand what you meant by this: "Its probably a bit confusing at 1st to have debug=INFO, but this is intentional; it tells you the logging level thats coded (so you dont have to go back to the source everytime), and therefore what is done if the config-line is commented out." * Question: If a module author decides to ship his module with Log::Log4perl::AutoCategorize, will it work if the main program (1) doesn't use it? (2) uses plain Log::Log4perl? * As for shipping it with Log::Log4perl ... you're depending on optimizer.pm which depends on 5.7.2 -- and Log::Log4perl works with 5.005_03. I think you're gonna be better off shipping it as a separate module to CPAN, this way you're free in what modules you depend on and don't have to support odd configurations (perl 5.005_03, Windows). We'll certainly provide a plug for Log::Log4perl::AutoCategorize within the Log::Log4perl docs. -- Mike Mike Schilli log...@pe... http://perlmeister.com http://log4perl.sourceforge.net |