From: James.FitzGibbon <Jam...@ta...> - 2003-05-02 16:22:28
|
Definately a good idea. Do you want me to integrate that in, or will you? I'm not sure how my patch is applying against what is in the CVS repository, so I don't want to cause too many rejected hunks. 8-) -- j. James FitzGibbon Consultant, Ajilon Services, TTS-3D@CC-950 jam...@ta... voice/fax 612-304-6121/3277 > -----Original Message----- > From: msc...@ao... [mailto:msc...@ao...] > Sent: Friday, May 02, 2003 11:16 AM > To: Jam...@ta...; log...@li... > Subject: Re: [log4perl-devel] For consideration: patch to use Safe > compart ments in Log::Log4per l::Config > > > In a message dated 5/2/2003 8:40:45 AM Eastern Standard Time, > Jam...@ta... writes: > > > Looks good to me. I will also try to take a stab at > writing a recipe for > > the list/FAQ on how to use the new functionality. > > Great idea, please do. I just had one more thought on the > global variables: We should probably keep them, but hide > access to them behind class accessor methods like > > Log::Log4perl::Config::allowed_code_ops(@array); #Set/Gets > Log::Log4perl::Config::vars_shared_with_safe_compartment(@vars); > Log::Log4perl::Config::allowed_code_ops_convenience_map(\%map); > > This way, if we decide to change the way they work (like in > the future global for all logger repositories or local for > the current one), we're flexible. What do you think? > > -- Mike > > ############################ > # Mike Schilli # > # log...@pe... # > # http://perlmeister.com # > # log4perl.sourceforge.net # > ############################ > |