RE: [log4perl-devel] For consideration: patch to use Safe compart ments in Log::Log4per l::Config

[James.FitzGibbon <Jam...@ta...>]

Looks good to me.  I will also try to take a stab at writing a recipe for
the list/FAQ on how to use the new functionality.

Thanks.

--
j.

James FitzGibbon                    
Consultant, Ajilon Services, TTS-3D@CC-950 
jam...@ta...
voice/fax 612-304-6121/3277




> -----Original Message-----
> From: msc...@ao... [mailto:msc...@ao...]
> Sent: Friday, May 02, 2003 12:36 AM
> To: Jam...@ta...; log...@li...
> Subject: Re: [log4perl-devel] For consideration: patch to use Safe
> compartments in Log::Log4per l::Config
> 
> 
> In a message dated 5/1/2003 7:06:44 PM Eastern Standard Time, 
> Jam...@ta... writes:
> 
> > 
> > Attached is a patch that implements the change I describe 
> in my message to
> > Mike
> > Schilli earlier today.
> 
> Wonderful, thanks!
> 
> > - the use of a Safe compartment is not enforced for the 
> user-defined cspecs
> 
> I've changed that. Please verfiy the attached modified patch 
> (it's against the current CVS version).
> 
> > The amount of information in
> > the
> > package globals really makes me feel like this information 
> needs to go
> > somewhere
> > else, but I don't know where.  I'm open to suggestions.
> 
> Ideally, I think we should get rid of the globals (although 
> we might need to provide backwards-compatibility for the one 
> we have) and add the code restriction control via methods of 
> the currently active Log4perl instance out of the Log4perl 
> repository. Right now, we don't have a repository -- so the 
> globals are ok. Backward comp issues remain of course.
> 
> > - The POD explaining how the Safe compartment restrictions 
> work is in
> > Log/Log4perl.pm
> > right now, and is a bit verbose.  
> 
> I think it's great!
> 
> Please check the attached patch and let me know if you want 
> it in like that.
> 
> -- Mike
> 
> ############################
> # Mike Schilli             #
> # log...@pe... #
> # http://perlmeister.com   #
> # log4perl.sourceforge.net #
> ############################
>