Re: [log4perl-devel] For consideration: patch to use Safe compartments in Log::Log4per l::Config

[<msc...@ao...>]

In a message dated 5/1/2003 7:06:44 PM Eastern Standard Time, Jam...@ta... writes:

> 
> Attached is a patch that implements the change I describe in my message to
> Mike
> Schilli earlier today.

Wonderful, thanks!

> - the use of a Safe compartment is not enforced for the user-defined cspecs

I've changed that. Please verfiy the attached modified patch (it's against the current CVS version).

> The amount of information in
> the
> package globals really makes me feel like this information needs to go
> somewhere
> else, but I don't know where.  I'm open to suggestions.

Ideally, I think we should get rid of the globals (although we might need to provide backwards-compatibility for the one we have) and add the code restriction control via methods of the currently active Log4perl instance out of the Log4perl repository. Right now, we don't have a repository -- so the globals are ok. Backward comp issues remain of course.

> - The POD explaining how the Safe compartment restrictions work is in
> Log/Log4perl.pm
> right now, and is a bit verbose.  

I think it's great!

Please check the attached patch and let me know if you want it in like that.

-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################