RE: [log4perl-devel] RFC: Log4perl Custom Filters Design Proposal

[<msc...@ao...>]

I've thought a bit more about the OK and DECLINED constants and was almost ready to put them in -- but then I realized that I would have to put them into the main: package, because the sub {...} filters are running in main: so people can use subroutines they've defined in main. I don't want Log4perl inject OK to main, though, that's too intrusive, so I'll leave them out unless someone comes up with a smart idea.

Regarding renaming the decide() subroutine, the only catchy naming idea I had stressing the binary nature of the call was ok() or approve(). Log4perl would call every custom filter's ok()/approve() method to determine the result of a Boolean filter. On the other hand, at least one developer I know of has already been using the new interface -- any newly developed custom filters would have to be adapted. Using the standard custom filters that ship with Log4perl will be possible without code changes. Votes?

-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################