Re: [log4perl-devel] Patch for suggested new behaviour

[Mike S. <msc...@ao...>]

ke...@go... wrote:

> > * Also, I thought that filter_message would be a code ref which could
> > be used to manipulate logger arguments? I think the appender should
> > be able to correct any log statement argument list (like limit it to
> > the number of arguments it expects etc.)
>
> Yes, it is, see Appender.pm line 135:
>
>    #filter_message is defined and true
>     }else{
>         $p->{message} =
>             $self->{filter_message}->($p->{message}); #syntax ok for 
> perl5?
>     } 

Just inspected your changes to the docs, now it's much clearer! One 
piece is left over, though: Somewhere in a log4j conf file sample you say

    log4j.appender.DBAppndr.filter_message = 1

but that should be a code ref, right?

>
>
> But it still needs testing, documentation, and accessor methods in 
> appender.  I can do them unless you get around to it first. 

I'll have a closer look tonight ...

> > * could you please add some comments to the "Changes" file (also
> > about the XML-DOM addition)
>
> Done, thanks for reminding me.  Did I forget anything? 

Looks good!

> > * I've corrected Ceki's name in the DOMConfiguration docs with
> > umlauts, these crazy Europeans are so adamant about it :)
>
> I was wondering how to approach those. I'm don't think using character 
> 0xFC for u-with-diaeresis will translate into systems using other 
> non-ISO8859 character sets (like DOS using CP437 or Macs using 
> MacRoman).  But I didn't feel like rebooting into Windows just to 
> check the file in EDIT, so that's cool.

I've eliminated "DOS" and "Mac" from my dictionary :). Not having 
umlauts on the US keyboard is tough, I'm facing the problem when I write 
in German. For now, I'm using the notation a^ o^ u^ A^ O^ U^ s^ for 
Umlauts and a Perl conversion script like

#!/usr/bin/perl -n -i -w

  s/a\^/\344/g;
  s/o\^/\366/g;
  s/u\^/\374/g;

  s/A\^/\304/g;
  s/O\^/\326/g;
  s/U\^/\334/g;

  s/s\^/\337/g;

  print $_;

which I run on the edited file afterwards. Works pretty good!

>
>
> > Also, is there a URL to the original spec we could add?
>
> Not really, their only "spec" is the log4j DTD and I didn't want to 
> write a link to that since it's buried in their site and could very 
> well move around.  When I finish implementing our additions, I'm going 
> to circulate a log4perl DTD for comments and then include it in our 
> distribution.  But I did add a note to see t/038XML-DOM1.t for examples. 

I see. Maybe a short example would illustrate it enough for new users to 
get the concept - - maybe even in the main Log4perl documentation, with 
a link to the "real" doc. When I get around to it ...

-- 
-- Mike

Mike Schilli
log...@pe...