Re: [log4perl-devel] Patch for suggested new behaviour

[<msc...@ao...>]

In a message dated 1/20/2003 12:40:27 PM Eastern Standard Time, Kevin Goess <ke...@go...> writes:

>The new stuff is checked in, all tests pass.

That's great news, thanks! Couple of notes:

* in the DBI appender's docs, the sentence "You can mix up the order the placeholders with %x specifiers as you see fit" seems to be missing an "of" and I'm confused about what the %x specifier does in this context.

* What happens in case PatternLayout is chosen instead of NoopLayout? Probably needs to be documented.

* Also, I thought that filter_message would be a code ref which could be used to manipulate logger arguments? I think the appender should be able to correct any log statement argument list (like limit it to the number of arguments it expects etc.)

* could you please add some comments to the "Changes" file (also about the XML-DOM addition)

* I've corrected Ceki's name in the DOMConfiguration docs with umlauts, these crazy Europeans are so adamant about it :) Also, is there a URL to the original spec we could add?

BTW, I'm gonna add a couple of test cases for the new { filter => \&filter, value => $value} syntax.

All test cases run fine on my box, too, looks good so far!
 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################