Re: [log4perl-devel] Patch for suggested new behaviour

[Mike S. <msc...@ao...>]

ke...@go... wrote:

> - input_filter as a property of an appender in the config, normally is
>not defined, but can be defined and false or set to...what? a coderef? 
>Would need to implement set_input_filter method in Appender.pm.
>
Yeah, that's much better! Only thing that could happen now is that some 
appender would want to define a default filter (like DBI cutting off 
excess fields) which could be slipped in via setting 
$p->{filter_message}in the appender's constructor and potentially 
overridden by a config file setting. Nice. Yeah, set_input_filter() 
would be useful.

> - I'm still not sure how this will interact with jcromie are talking
>about, but it's more than I can keep in my head at one time.
>
Do you mean the {filter => \&filter, value => "val"} syntax? That should 
work fine, because it's evaluated before the input_filter potentially 
kicks in.

If you meant the "autocategorize" stuff, that should be independent (and 
it's not yet decided if it's going to be in).

One more thing: currently, there's no check (in my part of the patch, 
sorry about that :) if someone writes something stupid like
    {feelter => \&filter, value => "val"}
The result would be somewhat nasty. In case we get a hashref, we should 
probably check that both "filter" and "value" are present.      

Otherwise -- looks good to me to check in, thanks for fixing! :)

-- 
-- Mike

Mike Schilli
log...@pe...