Re: [log4perl-devel] Patch for suggested new behaviour

[Mike S. <msc...@ao...>]

ke...@go... wrote:

> Are you guaranteeing that no Log::Dispatch::* class will ever have a 
> subroutine called "input_filter"?

Well, admittedly, that's somewhat sloppy right now. Although, long term 
we need a more generalized appender interface anyway -- but we can't 
finalize that right now, because we don't know yet which crazy ideas 
we're gonna come up with in the future ;).

> And why call a method *all* the time when *most* of the time we're 
> just doing a join? 

Good point. It's clearly unnecessary to call input_filter() every time. 
That could be changed to cache the default behaviour (join) and do it in 
Log::Log4perl::Appender.

> How about something like this instead.  Munging the message should be 
> a function of the Layout class, shouldn't it?  

Hmm, really? Isn't it up to the appender to decide which format it 
likes/needs? Shouldn't it be a property of the appender?

> If need be, I might have time tonight to generate a patch for 
> discussion purposes.

Good idea -- think that would help clear things up.

-- 
-- Mike

Mike Schilli
log...@pe...