From: <msc...@ao...> - 2003-01-14 09:43:54
|
Hey Kevin, here's a patch implementing what I've suggested earlier -- I haven't tested the new functionality extensivly, but the patch passes the existing test suite. There's a couple of open issues : [1] There's a "join" command in generate_noop_coderef() which concatenates the message chunks together to somehow log the message later if a config_and_watch event occurs. Think that won't work even with the old DBI appender -- right ;) ? [2] In case a log event passes several message chunks on to an appender, could there be appenders which want to render each chunk individually? Just a thought, maybe not. The code in the patch is not well commented, hope it's somehow decipherable :) Basically what I did is slip in a default input_filter method into the filter's package if it doesn't define one. The input_filter method will take a array ref of parameters (always) and return either a single string (in case the appender wants to collapse) or an array ref with the new elements. Arguments to debug(), info(), etc. are now plain arguments, hashes indicate parameter with special filtering needs. Code refs is also evaluated. Please let me know if that all makes sense ... :) -- -- Mike ############################ # Mike Schilli # # log...@pe... # # http://perlmeister.com # # log4perl.sourceforge.net # ############################ |