From: Kevin G. <ke...@go...> - 2002-11-08 17:34:14
|
>> And even better, check this out, how about user-assigned format >> specifiers at runtime in the config file? (The diff doesn't work as a >> patch, dunno why, but you can apply the .rej by hand) > > Way cool! It deviates from the log4j spec, but it's a handy feature. > Question is if we should put it into PatternLayout.pm or create a subclass? I don't know. If we're deviating from their spec it seems like we should subclass it. On the other hand, it's pretty obvious from the perl code in the config file that there's perl-specific stuff going on, and subclassing would hurt performance. I'd say, if we're already breaking compatibility with %P and %H, this isn't any worse than that. What do you think? Once I feel a consensus I need to add error checking, unit tests, and maybe some documentation. -- Happy Trails . . . Kevin M. Goess (and Anne and Frank) 904 Carmel Ave. Albany, CA 94706 (510) 525-5217 |