[log4perl-devel] log4perl bug when using Log::Dispatch::ApacheLog appender

[davis m. <da...@ep...>]

first thanks the great work developing the log4perl module, i am
integrating into our web applications and discovered a problem
while using Log::Dispatch::ApacheLog as an appender

in Logger.pm the generate_coderef function creates the subroutine
to call the log function of the appender...the call is coded as:

          \$appender->log(
              #these get passed through to Log::Dispatch
              { name    => \$appender_name,
                level   => 0,
                message => \$message,
              },
              #these we need
              \$logger->{category},
              \$level,
          );

with the ApacheLog module the value of the 'level' key in the hash is
used as the method name on the Apache Log API...since this was hardcoded
to 0 the method call failed...

i changed this code to

          \$appender->log(
              #these get passed through to Log::Dispatch
              { name    => \$appender_name,
                level   => lc(\$level),    <------MODIFIED LINE
                message => \$message,
              },
              #these we need
              \$logger->{category},
              \$level,
          );

and it worked like a champ as far as logging to Apache was concerned...

But I have not studied the Log4perl code enough to know if this is the
proper way to fix this...

So if you guys have already fixed this or can comment on this patch 
i would greatly appreciate any information...

again...thanks for the great job i'm looking forward to using this
package extensively in our future development


davis


-- 
davis mcpherson <da...@ep...>