From: Erik S. <er...@se...> - 2002-08-27 07:48:09
|
Here ya go. Also made a new patch file, as the tests caught a bug (woot!). I forgot to wrap the various incarnations of warn() around a $self->is_warn(), which means it would print out warnings to STDERR but not log 'em. I also noticed that there's no turning off FATAL logging. Not sure if that's a good thing or not myself... although it certainly makes things like logdie() always work, regardless if you turn off all logging whatsoever. -e Msc...@ao... wrote: > In a message dated 8/16/02 11:36:06 PM Pacific Daylight Time, > er...@se... writes: > > >> For consideration: a patch that has sundry logdie / logcroak and >> similar. > > > > Sorry for the long delay, Erik, just found some time to look at your > patch. Very nice! It's going to be a bit slower than "log && warn" > (another level on the call stack), but that's the price for > convenience. I'll apply the patch -- can you add a few test cases? > > -- Mike > log...@pe... |