From: Alexander H. <ale...@gm...> - 2013-01-25 10:43:03
|
On Fri, Jan 25, 2013 at 12:43 AM, Alexander Hartmaier < ale...@gm...> wrote: > Hi Michael, > currently I haven't put the code anywhere public but I'll fork the > log4perl github repo if I have time tomorrow, commit my code and send the > pull request. > I think I haven't written tests for it though... > > Best regards, Alex > > > On Thu, Jan 24, 2013 at 4:57 AM, Mike Schilli <m...@pe...> wrote: > >> On Wed, 23 Jan 2013, Alexander Hartmaier wrote: >> >> I've written a Log::Log4perl::Filter::MDC filter cause I have to send >>> errors to different teams which I implemented by defining each teams >>> >> >> Hi Alex, >> >> that sounds great, do you have the code anywhere where we can take >> a look? Hard to say without looking at it if the best way is to merge it >> into the main Log4perl distribution or to roll your own CPAN package. If >> its generally useful, then by all means, lets integrate it. The easiest >> way to do that is forking the github repo at >> >> https://github.com/mschilli/**log4perl<https://github.com/mschilli/log4perl> >> >> then add your changes and send a pull request. >> >> Let me know if you need more detailed instructions. >> > I've written some tests, updated the list of contributors and sent a pull-request. I've also changed the list of contributors to be a list which is more git friendly when it comes to adding a new contributor. >> -- >> -- Mike >> >> Mike Schilli >> m...@pe... >> >> >> email address as appender and filter on a MDC value (the support group >>> which maps to each team). Should I release it to CPAN as separate >>> dist or do you want to include it in the Log::Log4perl dist? It adds >>> no dependencies and follows the Log::Log4perl naming for config keys. >>> >>> Best regards, Alex >>> >>> >>> > |