Re: [log4perl-devel] logwarn not calling warn if L::L's init not called

[Martin J. E. <mar...@ea...>]

On 24/12/11 01:01, Mike Schilli wrote:
> On Mon, 21 Nov 2011, Martin J. Evans wrote:
>
>> Would you consider changing this? If not, I would be most grateful if
>> you could you point me at the place where I could change this
>> behaviour or tell my how I could override it.
>
> Alright, I gave in and fixed it :)

Excellent and thank you.

> https://github.com/mschilli/log4perl/commit/7d7fbbb45254d6c903f5b3cb91d7
>
> Thanks for bringing this to my attention. Please give it a whirl!

I have /whirled/ it and it a) now warns when it didn't before and b) seems to still work in all other ways we are using it.

Thanks again.

Martin
-- 
Martin J. Evans
Easysoft Limited
http://www.easysoft.com

>
>>
>> Martin
>>
>>>> Hi,
>>>>
>>>> Is this really the intended behaviour:
>>>>
>>>> perl -w -le 'use strict;use warnings;use Log::Log4perl qw(get_logger); my $lh = get_logger("BET::Data::Remove"); $lh->debug("fred");$lh->logwarn("warning from l:l"); warn("warning");'
>>>>
>>>> Log4perl: Seems like no initialization happened. Forgot to call init()?
>>>> warning at -e line 1.
>>>>
>>>> i.e., if something does not call init for Log::Log4perl but has a log handle when logwarn is called a warn does not happen?
>>>>
>>>
>>>>
>>>> I spent some time debugging a problem this morning only to discover this. I find this most worrying as I'd expect the warn to happen whatever. If you substitute logdie for die it seems to work.
>>>>
>>>> perl -MLog::Log4perl -le 'print $Log::Log4perl::VERSION;'
>>>> 1.33
>>>> This is perl, v5.10.1 (*) built for i686-linux-gnu-thread-multi
>>>>
>>>> Martin
>>>>
>>
>>
>>
>