log4perl-devel

[Erik W.S. <er...@se...>]

Hey guys,

First off, great port! Just getting my feet wet with it and it's
looking much better than my crappy three-line _log function I ripped
somewhere.

I have one suggestion: my existing _log function looks like:

my $v; # global verbosity string
sub _log {
  my $l = shift;
  print @_ if ($v >= $l);
}

I noticed that log looks like:

sub log {
# external api
##################################################
    my ($self, $priority, $message) = @_;

    croak "priority $priority isn't numeric" if ($priority =~ /\D/);

    my $which = Log::Log4perl::Level::to_level($priority);

    $self->{$which}($self, $message, Log::Log4perl::Level::to_level($priority));

}

Thus, $logger->warn("foo", "bar", "baz") will only print "foo".

Might a more general way to handle things look like:

sub log {
# external api
##################################################
    my $self = shift;
    my $priority = shift;
    my $message = join("", @_);

    croak "priority $priority isn't numeric" if ($priority =~ /\D/);

    my $which = Log::Log4perl::Level::to_level($priority);

    $self->{$which}($self, $message, Log::Log4perl::Level::to_level($priority));

}

?

Thanks,
-e

-- 
				Erik Selberg
"I get by with a little help	er...@se...
 from my friends."		http://www.selberg.org