log4perl-devel

Re: [log4perl-devel] actual bug in new Logger.pm

[<Msc...@ao...>]

In a message dated 1/24/03 10:16:47 AM Pacific Standard Time, ke...@go... 
writes:

> Mike, I found a problem with this guy in Logger.pm
> 
> \$message   = [map { ref \$_ eq "HASH" ?
> 

Yup, think I brought that up a while ago (misspelling "filter" like 
"feelter", remember :) but it fell through the cracks somehow ... your fix 
looks good!

-- Mike
log...@pe...

[log4perl-devel] Re: actual bug in new Logger.pm

[<msc...@ao...>]

In a message dated 1/24/2003 1:14:34 PM Eastern Standard Time, Kevin Goess <ke...@go...> writes:

>\$message   = [map { ref \$_ eq "HASH"
>        && exists \$_->{filter}
>        && ref \$_->{filter} eq "CODE" ?

You had it right here but checked it in differently :) -- so it failed test #49 in 002Logger.t. Here's the fix, I've checked it in:

diff -a -u -r1.44 Logger.pm
--- lib/Log/Log4perl/Logger.pm  24 Jan 2003 20:09:55 -0000      1.44
+++ lib/Log/Log4perl/Logger.pm  25 Jan 2003 16:35:55 -0000
@@ -211,7 +211,9 @@
       #     => coderef()
       #
 
-      \$message   = [map { ref \$_ eq "HASH" && exists \$_->{filter} && \$_->{filter} eq 'CODE' ?
+      \$message   = [map { ref \$_ eq "HASH" && 
+                           exists \$_->{filter} && 
+                           ref \$_->{filter} eq 'CODE' ?
                                \$_->{filter}->(\$_->{value}) :
                            ref \$_ eq "CODE" ?
                                \$_->() : \$_ 

-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################