log4perl-devel

[log4perl-devel] triggers, subs-in-subs

[Kevin M. G. <cp...@go...>]

Hey, Mike, per the note I just sent to Robert Jacobson, it looks like
the implementation of triggers doesn't match the docs.  Something like
this actually gets compiled and run when the config is loaded, but we
just want it compiled, it shouldn't be run until the trigger is called:

 log4perl.appender.Buffer.trigger = sub {return 99};

That results in Buffer.trigger being assigned a value of 99, instead of
a CODE(x123123) ref.

Attached is a quick fix that will produce the desired behavior.  I
haven't fixed the docs in Buffer.pm.  And is there a better way to do
priority comparisons than what I put in the test?  Sorry, I'm in a
hurry, I'll try to look at it more tonight.

What do you think?

-- 
Happy Trails . . .

Kevin M. Goess

Re: [log4perl-devel] triggers, subs-in-subs

[Mike S. <m...@pe...>]

On Tue, 13 Mar 2007, Kevin M. Goess wrote:

> Hey, Mike, per the note I just sent to Robert Jacobson, it looks like
> the implementation of triggers doesn't match the docs.

Good catch, thanks for the fix!

> Attached is a quick fix that will produce the desired behavior.  I
> haven't fixed the docs in Buffer.pm.  And is there a better way to do
> priority comparisons than what I put in the test?  Sorry, I'm in a
> hurry, I'll try to look at it more tonight.

If you use

    use Log::Log4perl::Level;

then the $DEBUG, $INFO, etc. constants are exported into the main
namespace and

    Log::Log4perl::Level::to_priority('ERROR')

can be written as

    $ERROR

but that's about it I think, and normally this kind of trigger
would be written as

    log4perl.appender.Buffer.trigger_level = ERROR

anyway ;).

Thanks again!

-- Mike

Mike Schilli
m...@pe...