From: Mike S. <msc...@ao...> - 2003-01-30 18:33:04
|
Looks like this is related, can you also please check the other warning with syslog shown below? Since CPAN doesn't allow for updating the same version, we should probably just go ahead and prepare 0.29 right away. Want to roll in your patch into the tip? It's no biggie if we fix it real soon. Longer term, I think we also need to run tests for the different cases of optional modules being present or absent. -- Mike Mike Schilli log...@pe... Jos...@ru... wrote: >This distribution has been tested as part of the cpan-testers >effort to test as many new uploads to CPAN as possible. See >http://testers.cpan.org/ > >Please cc any replies to cpa...@pe... to keep other >test volunteers informed and to prevent any duplicate effort. > >-- >This is an error report generated automatically by CPANPLUS, >version 0.042. > >Below is the error stack during 'make test': > >PERL_DL_NONLAZY=1 /usr/local/perl/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t >t/001Level...........ok >t/002Logger..........ok >t/003Layout..........ok >t/004Config..........ok >t/005Config-Perl.....ok >t/006Config-Java.....ok >t/007LogPrio.........ok >t/008ConfCat.........ok >t/009Deuce...........ok >t/010JConsole........ok >t/011JFile...........ok >t/012Deeper..........ok >t/013Bench...........ok >t/014ConfErrs........ok >t/015fltmsg..........ok >t/016Export..........ok >t/017Watch...........ok >t/018Init............ok >t/019Warn............ok >t/020Easy............ok >t/021AppThres........ok >t/022Wrap............ok >t/023Date............ok >t/024WarnDieCarp.....ok >t/025CustLevels......ok >t/026FileApp.........ok >t/027Watch2..........ok >t/028Additivity......ok >t/029SysWide.........ok >t/030LDLevel.........ok >t/031NDC.............ok >t/032JRollFile.......ok >t/033UsrCspec........ok >t/034DBI.............ok >t/035JDBCAppender....ok >t/036JSyslog.........unix passed to setlogsock, but path not available at /usr/local/perl/lib/site_perl/5.8.0/Log/Dispatch/Syslog.pm line 66 >ok >t/037JWin32Event.....Log::Dispatch::Win32EventLog not installed, skipping.. >ok >t/038XML-DOM1........# Test 1 got: '$VAR1 = { > 'appender' => { > 'BUF0' => { > 'layout' => { > 'value' => 'Log::Log4perl::Layout::SimpleLayout' > }, > 'value' => 'Log::Log4perl::Appender::TestBuffer', > 'Threshold' => { > 'value' => 'ERROR' > } > }, > 'A1' => { > 'layout' => { > 'value' => 'Log::Log4perl::Layout::SimpleLayout' > }, > 'value' => 'Log::Log4perl::Appender::TestBuffer' > }, > 'A2' => { > 'layout' => { > 'value' => 'Log::Log4perl::Layout::SimpleLayout' > }, > 'value' => 'Log::Log4perl::Appender::TestBuffer' > }, > 'FileAppndr1' => { > 'Append' => { > 'value' => 'false' > }, > 'layout' => { > 'ConversionPattern' => { > 'value' => '%d %4r [%t] %-5p %c %t - %m%n' > }, > 'value' => 'Log::Log4perl::Layout::PatternLayout' > }, > 'value' => 'org.apache.log4j.FileAppender', > 'File' => { > 'value' => 't/tmp/DOMtest' > } > } > }, > 'additivity' => { > 'a' => { > 'b' => { > 'c' => { > 'd' => { > 'value' => '0' > } > } > } > } > }, > 'threshold' => { > 'value' => 'DEBUG' > }, > 'category' => { > 'a' => { > 'b' => { > 'c' => { > 'd' => { > 'value' => 'WARN, A1' > } > }, > 'value' => 'INFO, A1' > } > }, > 'value' => 'WARN, FileAppndr1', > 'xa' => { > 'b' => { > 'c' => { > 'd' => { > 'value' => 'INFO, A2' > } > }, > 'value' => 'WARN, A2' > } > }, > 'animal' => { > 'value' => 'INFO, FileAppndr1', > 'dog' => { > 'value' => 'INFO, FileAppndr1,A2' > } > } > } > }; >' (t/038XML-DOM1.t at line 135) ># Expected: '$VAR1 = { > 'appender' => { > 'BUF0' => { > 'layout' => { > 'value' => 'Log::Log4perl::Layout::SimpleLayout' > }, > 'value' => 'Log::Log4perl::Appender::TestBuffer', > 'Threshold' => { > 'value' => 'ERROR' > } > }, > 'A1' => { > 'layout' => { > 'value' => 'Log::Log4perl::Layout::SimpleLayout' > }, > 'value' => 'Log::Log4perl::Appender::TestBuffer' > }, > 'A2' => { > 'layout' => { > 'value' => 'Log::Log4perl::Layout::SimpleLayout' > }, > 'value' => 'Log::Log4perl::Appender::TestBuffer' > }, > 'FileAppndr1' => { > 'Append' => { > 'value' => 'false' > }, > 'layout' => { > 'ConversionPattern' => { > 'value' => '%d %4r [%t] %-5p %c %t - %m%n' > }, > 'value' => 'Log::Log4perl::Layout::PatternLayout' > }, > 'value' => 'org.apache.log4j.FileAppender', > 'File' => { > 'value' => 't/tmp/DOMtest' > } > } > }, > 'additivity' => { > 'a' => { > 'b' => { > 'c' => { > 'd' => { > 'value' => '0' > } > } > } > } > }, > 'threshold' => { > 'value' => 'DEBUG' > }, > 'category' => { > 'a' => { > 'b' => { > 'c' => { > 'd' => { > 'value' => 'WARN, A1' > } > }, > 'value' => 'INFO, A1' > } > }, > 'value' => 'WARN, FileAppndr1', > 'xa' => { > 'b' => { > 'c' => { > 'd' => { > 'value' => 'INFO, A2' > } > }, > 'value' => 'WARN, A2' > } > }, > 'animal' => { > 'dog' => { > 'value' => 'INFO, FileAppndr1,A2' > }, > 'value' => 'INFO, FileAppndr1' > } > } > }; >' >FAILED test 1 > Failed 1/1 tests, 0.00% okay >Failed Test Stat Wstat Total Fail Failed List of Failed >------------------------------------------------------------------------------- >t/038XML-DOM1.t 1 1 100.00% 1 ># t/038XML-DOM1.t line 135 is: ok(Dumper($xmldata),Dumper($propsdata)); >Failed 1/38 test scripts, 97.37% okay. 1/368 subtests failed, 99.73% okay. >make: *** [test_dynamic] Error 29 > > >Additional comments: > >-- > >Summary of my perl5 (revision 5.0 version 8 subversion 0) configuration: > Platform: > osname=solaris, osvers=2.8, archname=sun4-solaris > uname='sunos sunu991 5.8 generic_108528-14 sun4u sparc ' > config_args='-de' > hint=recommended, useposix=true, d_sigaction=define > usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef > useperlio=define d_sfio=undef uselargefiles=define usesocks=undef > use64bitint=undef use64bitall=undef uselongdouble=undef > usemymalloc=n, bincompat5005=undef > Compiler: > cc='gcc', ccflags ='-fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', > optimize='-O', > cppflags='-fno-strict-aliasing -I/usr/local/include' > ccversion='', gccversion='3.0', gccosandvers='solaris2.8' > intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=4321 > d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16 > ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 > alignbytes=8, prototype=define > Linker and Libraries: > ld='gcc', ldflags =' -L/usr/local/lib ' > libpth=/usr/local/lib /usr/lib /usr/ccs/lib > libs=-lsocket -lnsl -lgdbm -ldb -ldl -lm -lc > perllibs=-lsocket -lnsl -ldl -lm -lc > libc=/lib/libc.so, so=so, useshrplib=false, libperl=libperl.a > gnulibc_version='' > Dynamic Linking: > dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags=' ' > cccdlflags='-fPIC', lddlflags='-G -L/usr/local/lib' > > |
From: Kevin G. <ke...@go...> - 2003-01-30 18:54:58
|
Mike Schilli wrote: > Looks like this is related, Yeah, Data::Dumper doesn't always return data in the same order, darn it. My changes to the rel-0-28 branch will fix the failure of 038XML-DOM1.t. > can you also please check the other warning > with syslog shown below? >> t/036JSyslog.........unix passed to setlogsock, but path not available >> at /usr/local/perl/lib/site_perl/5.8.0/Log/Dispatch/Syslog.pm line 66 I don't have access to a solaris box, the problem looks like it's in Log::Dispatch::Syslog, it might have to do with the individual system setup. We could just take the test out, but on the other hand it might be telling us something useful here. I'm not sure what to do--what do you think? > Since CPAN doesn't allow for updating the same version, we should > probably just go ahead and prepare 0.29 right away.Want to roll in your > patch into the tip? It's no biggie if we fix it real soon. See my earlier email, the CVS branch rel-0-28 is releasable. > Longer term, I think we also need to run tests for the different cases > of optional modules being present or absent. Eh? I don't follow you? -- Happy Trails . . . Kevin M. Goess (and Anne and Frank) 904 Carmel Ave. Albany, CA 94706 (510) 525-5217 |
From: Kevin G. <ke...@go...> - 2003-01-30 19:14:50
|
Kevin Goess wrote: > Mike Schilli wrote: > >> can you also please check the other warning with syslog shown below? > > >> t/036JSyslog.........unix passed to setlogsock, but path not available > >> at /usr/local/perl/lib/site_perl/5.8.0/Log/Dispatch/Syslog.pm line 66 > > I don't have access to a solaris box, the problem looks like it's in > Log::Dispatch::Syslog, it might have to do with the individual system > setup. We could just take the test out, but on the other hand it might > be telling us something useful here. I'm not sure what to do--what do > you think? On the other hand, it looks like Log::Dispatch has seen problems here, stemming from Sys::Syslog: http://testers.cpan.org/search?request=dist&dist=Log-Dispatch How about I disable the test but leave it in there to help people diagnose problems if they want to use it? -- Happy Trails . . . Kevin M. Goess (and Anne and Frank) 904 Carmel Ave. Albany, CA 94706 (510) 525-5217 |
From: Mike S. <msc...@ao...> - 2003-01-30 21:10:06
|
ke...@go... wrote: > > I don't have access to a solaris box, the problem looks like it's in > Log::Dispatch::Syslog, it might have to do with the individual system > setup. We could just take the test out, but on the other hand it might > be telling us something useful here. I'm not sure what to do--what do > you think? I'll try with a Solaris box ... and is the Log::Dispatch::Syslog test case new in 0.28? > Since CPAN doesn't allow for updating the same version, we should > probably just go ahead and prepare 0.29 right away.Want to roll in your > > See my earlier email, the CVS branch rel-0-28 is releasable. Can you check it into 0.29? That's easier for me to handle. > Longer term, I think we also need to run tests for the different cases > of optional modules being present or absent. > > Eh? I don't follow you? I just meant we need to test both cases, with and without the optional modules present. -- -- Mike Mike Schilli log...@pe... |
From: Mike S. <msc...@ao...> - 2003-01-30 21:24:37
|
msc...@ao... wrote: > ke...@go... wrote: > >> >> I don't have access to a solaris box, the problem looks like it's in >> Log::Dispatch::Syslog, it might have to do with the individual system >> setup. We could just take the test out, but on the other hand it >> might be telling us something useful here. I'm not sure what to >> do--what do you think? > > > I'll try with a Solaris box ... and is the Log::Dispatch::Syslog test > case new in 0.28? Hmm ... all kinds of weird stuff happening on Solaris: t/001Level...........ok t/002Logger..........ok t/003Layout..........ok t/004Config..........ok t/005Config-Perl.....ok t/006Config-Java.....ok t/007LogPrio.........ok t/008ConfCat.........ok t/009Deuce...........ok t/010JConsole........ok t/011JFile...........ok t/012Deeper..........ok t/013Bench...........ok t/014ConfErrs........ok t/015fltmsg..........ok t/016Export..........ok t/017Watch...........# Test 1 got: 'INFO - info message INFO - 2nd info message INFO - 2nd info message again ' (t/017Watch.t at line 74) # Expected: 'INFO - info message DEBUG animal.dog - 2nd debug message INFO animal.dog - 2nd info message INFO animal.dog - 2nd info message again ' t/017Watch...........NOK 1# Test 2 got: 'INFO - info message INFO - 2nd info message INFO - 2nd info message again INFO - 3rd info message ' (t/017Watch.t at line 105) # Expected: 'INFO - info message DEBUG animal.dog - 2nd debug message INFO animal.dog - 2nd info message INFO animal.dog - 2nd info message again INFO - 3rd info message ' t/017Watch...........FAILED tests 1-2 Failed 2/2 tests, 0.00% okay t/018Init............ok t/019Warn............ok t/020Easy............ok t/021AppThres........ok t/022Wrap............ok t/023Date............ok t/024WarnDieCarp.....ok t/025CustLevels......ok t/026FileApp.........ok t/027Watch2..........NOK 2# Test 2 got: 'DEBUG - debug message, should appear DEBUG - debug message, should NOT appear ' (t/027Watch2.t at line 79) # Expected: '' t/027Watch2..........NOK 3# Test 3 got: 'DEBUG - debug message, should appear DEBUG - debug message, should NOT appear WARN - warning message, should appear ' (t/027Watch2.t at line 83) # Expected: 'WARN - warning message, should appear ' t/027Watch2..........FAILED tests 2-3 Failed 2/5 tests, 60.00% okay t/028Additivity......ok t/029SysWide.........ok t/030LDLevel.........ok t/031NDC.............ok t/032JRollFile.......ok 1/1Log::Dispatch::FileRotate not installed, skipping... t/032JRollFile.......ok t/033UsrCspec........ok t/034DBI.............DBD::CSV not installed, skipping tests t/034DBI.............ok t/035JDBCAppender....DBD::CSV not installed, skipping tests t/036JSyslog.........unix passed to setlogsock, but path not available at /u/mschilli/PERL580/bin/perl/lib/site_perl/5.8.0/Log/Dispatch/Syslog.pm line 66 t/036JSyslog.........ok t/037JWin32Event.....Log::Dispatch::Win32EventLog not installed, skipping.. t/037JWin32Event.....ok t/038XML-DOM1........XML::DOM not installed, skipping tests t/038XML-DOM1........ok t/039XML-DOM2........XML::DOM not installed, skipping tests t/039XML-DOM2........ok -- Mike Mike Schilli log...@pe... |
From: Mark B. <md...@ji...> - 2003-01-31 00:40:00
|
>> On Thu, 30 Jan 2003 13:35:05 -0800, >> Mike Schilli(M) wrote: M> msc...@ao... wrote: M> Hmm ... all kinds of weird stuff happening on Solaris: Which version? On, $ uname -a SunOS xxxxxx 5.6 Generic_105181-11 sun4u sparc It looks mostly OK to me: PERL_DL_NONLAZY=1 /tmp/.zzzzzzzzzzDummyLongPathToRelocatezzzzzzzPerl/bin/perl -Iblib/arch -Iblib/lib -I/tmp/.zzzzzzzzzzDummyLongPathToRelocatezzzzzzzPerl/lib/perl5/5.6.1/sun4-solaris -I/tmp/.zzzzzzzzzzDummyLongPathToRelocatezzzzzzzPerl/lib/perl5/5.6.1 -e 'use Test::Harness qw(&runtests $verbose); $verbose=0; runtests @ARGV;' t/*.t t/001Level..........ok t/002Logger.........ok t/003Layout.........ok t/004Config.........ok t/005Config-Perl....ok t/006Config-Java....ok t/007LogPrio........ok t/008ConfCat........ok t/009Deuce..........ok t/010JConsole.......Possible attempt to separate words with commas at t/010JConsole.t line 9. ok t/011JFile..........Possible attempt to separate words with commas at t/011JFile.t line 6. ok t/012Deeper.........ok t/013Bench..........ok t/014ConfErrs.......ok t/015fltmsg........."my" variable $app masks earlier declaration in same scope at t/015fltmsg.t line 46. "my" variable $app masks earlier declaration in same scope at t/015fltmsg.t line 65. "my" variable $app masks earlier declaration in same scope at t/015fltmsg.t line 83. "my" variable $app masks earlier declaration in same scope at t/015fltmsg.t line 108. ok t/016Export.........ok t/017Watch..........ok t/018Init...........ok t/019Warn...........ok t/020Easy...........ok t/021AppThres.......ok t/022Wrap...........ok t/023Date...........ok t/024WarnDieCarp....ok t/025CustLevels.....ok t/026FileApp........ok t/027Watch2.........ok t/028Additivity.....ok t/029SysWide........ok t/030LDLevel........ok t/031NDC............ok t/032JRollFile......Log::Dispatch::FileRotate not installed, skipping... ok t/033UsrCspec.......ok t/034DBI............DBD::CSV not installed, skipping tests ok t/035JDBCAppender...DBD::CSV not installed, skipping tests ok t/036JSyslog........ok t/037JWin32Event....Log::Dispatch::Win32EventLog not installed, skipping.. ok t/038XML-DOM1.......XML::DOM not installed, skipping tests ok All tests successful. Files=38, Tests=343, 34 wallclock secs (18.59 cusr + 2.46 csys = 21.05 CPU) Using, $ perl -V Summary of my perl5 (revision 5.0 version 6 subversion 1) configuration: Platform: osname=solaris, osvers=2.6, archname=sun4-solaris uname='sunos xxxxxx 5.6 generic_105181-11 sun4u sparc ' config_args='-d' hint=previous, useposix=true, d_sigaction=define usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef useperlio=undef d_sfio=undef uselargefiles=undef usesocks=undef use64bitint=undef use64bitall=undef uselongdouble=undef Compiler: cc='gcc', ccflags ='-fno-strict-aliasing -I/usr/local/include -I/opt/local/include -I/opt/gnu/include', optimize='-O', cppflags='-fno-strict-aliasing -I/usr/local/include -I/opt/local/include -I/opt/gnu/include' ccversion='', gccversion='2.95.3 20010315 (release)', gccosandvers='solaris2.6' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=4321 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=4 alignbytes=8, usemymalloc=y, prototype=define Linker and Libraries: ld='gcc', ldflags =' -L/usr/local/lib -L/opt/local/lib -L/opt/gnu/lib' libpth=/usr/local/lib /opt/local/lib /opt/gnu/lib /usr/lib /usr/ccs/lib libs=-lsocket -lnsl -ldl -lm -lc perllibs=-lsocket -lnsl -ldl -lm -lc libc=/usr/lib/libc.so, so=so, useshrplib=false, libperl=libperl.a Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags=' ' cccdlflags='-fPIC', lddlflags='-G -L/usr/local/lib -L/opt/local/lib -L/opt/gnu/lib' Characteristics of this binary (from libperl): Compile-time options: Built under solaris Compiled at Oct 16 2002 17:58:15 @INC: /tmp/.zzzzzzzzzzDummyLongPathToRelocatezzzzzzzPerl/lib/perl5/5.6.1/sun4-solaris /tmp/.zzzzzzzzzzDummyLongPathToRelocatezzzzzzzPerl/lib/perl5/5.6.1 /tmp/.zzzzzzzzzzDummyLongPathToRelocatezzzzzzzPerl/lib/perl5/site_perl/5.6.1/sun4-solaris /tmp/.zzzzzzzzzzDummyLongPathToRelocatezzzzzzzPerl/lib/perl5/site_perl/5.6.1 /tmp/.zzzzzzzzzzDummyLongPathToRelocatezzzzzzzPerl/lib/perl5/site_perl /tmp/.zzzzzzzzzzDummyLongPathToRelocatezzzzzzzPerl/lib/site_perl/5.6.0/sun4-solaris /tmp/.zzzzzzzzzzDummyLongPathToRelocatezzzzzzzPerl/lib/site_perl/5.6.0 . |
From: Kevin G. <ke...@go...> - 2003-01-31 00:53:07
|
> t/036JSyslog.........unix passed to setlogsock, but path not available > at /u/mschilli/PERL580/bin/perl/lib/site_perl/5.8.0/Log/Dispatch/Syslog.pm line 66 Can you run this perl -Iblib/lib t/036JSyslog.t and send the output? I'm thinking Sys::Syslog has problems, maybe we should turn off the test. -- Happy Trails . . . Kevin M. Goess (and Anne and Frank) 904 Carmel Ave. Albany, CA 94706 (510) 525-5217 |
From: Mike S. <msc...@ao...> - 2003-01-31 01:07:44
|
ke...@go... wrote: > > t/036JSyslog.........unix passed to setlogsock, but path not > available > at > /u/mschilli/PERL580/bin/perl/lib/site_perl/5.8.0/Log/Dispatch/Syslog.pm > line 66 > > Can you run this > perl -Iblib/lib t/036JSyslog.t > and send the output? I'm thinking Sys::Syslog has problems, maybe we > should turn off the test. > > Just verified that you get the same error when you install Log::Dispatch on Solaris. So the warning is not related to Log::Log4perl. -- -- Mike Mike Schilli m...@pe... |
From: Mike S. <msc...@ao...> - 2003-01-31 01:12:02
|
BTW, the error with the scewed NFS time is quite severe. If someone installs Log::Log4perl on a NFS-based file system and the clocks are off by a few seconds, Log::Log4perl won't pass its test suite. I think the problem is that we rely on the fact that the system time (obtained via time()) and the file system's -M date are in sync. Wouldn't it be safer to store the -M time of the config file as soon as it has been written instead of using time() for config_and_watch? -- -- Mike Mike Schilli m...@pe... |
From: Kevin G. <ke...@go...> - 2003-01-31 01:00:14
|
>> Since CPAN doesn't allow for updating the same version, we should >> probably just go ahead and prepare 0.29 right away.Want to roll in your >> >> See my earlier email, the CVS branch rel-0-28 is releasable. > > Can you check it into 0.29? That's easier for me to handle. But I already checked a bunch of other work I'm doing on the XML-DOM into 0.29 which isn't ready to be released yet. Just to this in your cvs directory cvs update -r rel-0-28 to change your sources to the branch, do the release, and when you're finished you can do cvs update -A to switch your sources back to the main trunk. If you're using kde, cervisia is a cvs front-end with a nice tree-browsing feature that lets you see what's going on. > >> Longer term, I think we also need to run tests for the different cases >> of optional modules being present or absent. >> >> Eh? I don't follow you? > > I just meant we need to test both cases, with and without the optional > modules present. Umm, how do we test if the module isn't there? I think the tests and code are pretty well modularized, if some optional piece (like Win32::EventLog) is missing it doesn't affect anything else. -- Happy Trails . . . Kevin M. Goess (and Anne and Frank) 904 Carmel Ave. Albany, CA 94706 (510) 525-5217 |
From: Jim C. <jc...@di...> - 2003-01-31 23:36:07
|
Kevin Goess wrote: > > Mike Schilli wrote: > >> Looks like this is related, > > > Yeah, Data::Dumper doesn't always return data in the same order, darn it. $Data::Dumper::Sortkeys = 1; # alpha sort hash keys slows it down a bit, (never tested that - but it must), but predictabilty is good in logs. |
From: Kevin G. <ke...@go...> - 2003-02-01 00:13:51
|
Thanks for the tip, Jim. I tried it, and then noticed that Data::Dumper is also not consistent about putting quotes around hash values. I'm only using it in the test, to see whether the data structures returned by the parsers PropertiesConfigurator and DOMConfigurator are the same for equivalent configs. In t/038XML-DOM1.t I ended up stealing some code from Data::Compare to diff the data structures, all this just so we wouldn't have a dependency on Data::Dump. Jim Cromie wrote: > Kevin Goess wrote: > >> >> Mike Schilli wrote: >> >>> Looks like this is related, >> >> >> >> Yeah, Data::Dumper doesn't always return data in the same order, darn it. > > > > $Data::Dumper::Sortkeys = 1; # alpha sort hash keys > > slows it down a bit, (never tested that - but it must), > but predictabilty is good in logs. > > > > > > ------------------------------------------------------- > This SF.NET email is sponsored by: > SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! > http://www.vasoftware.com > _______________________________________________ > log4perl-devel mailing list > log...@li... > https://lists.sourceforge.net/lists/listinfo/log4perl-devel -- Happy Trails . . . Kevin M. Goess (and Anne and Frank) 904 Carmel Ave. Albany, CA 94706 (510) 525-5217 |
From: Jim C. <jc...@di...> - 2003-02-01 00:39:39
|
Kevin Goess wrote: > Thanks for the tip, Jim. I tried it, and then noticed that > Data::Dumper is also not consistent about putting quotes around hash > values. I'm only using it in the test, to see whether the data > structures returned by the parsers PropertiesConfigurator and > DOMConfigurator are the same for equivalent configs. > > In t/038XML-DOM1.t I ended up stealing some code from Data::Compare to > diff the data structures, all this just so we wouldn't have a > dependency on Data::Dump. I guess I wasnt reading very carefully wrt why you were using it, it reminded me of ============================================================ Log::Log4perl Recipe of the Week (#14): in which case it might be appropriate, since sorted structures are easier to eyeball for expected values, and for diffs vs other copies of the same logfiles. while were at it, $Data::Dumper::Indent = 1; is a 'better' format than the default: 2, which indents based on the string-length of the keys, and can thus look kinda ragged when a hash has $h = { 'shortkeys' => [ 1, 2 ], 'really-long-key-names-which-result-in-data-sensitive-indents' => [ 1, 2, ], }; but, since that was a user recipe, and not a function, this might reduce to Tip #14-a |