log4perl-devel

[log4perl-devel] precision in format specifiers

[Kevin G. <ke...@go...>]

While we're on the subbject of PatternLayout, is there any reason we're 
not including precision (aka max field width) in the sprintf format 
specifiers? We can do
	%20m
but not
	%20.20m

It's supported	in log4j 
(http://jakarta.apache.org/log4j/docs/api/org/apache/log4j/PatternLayout.html)

and the change is below, shall I put it in?



--- old/PatternLayout.pm        Thu Nov  7 10:13:11 2002
+++ lib/Log/Log4perl/Layout/PatternLayout.pm   Thu Nov  7 10:10:33 2002
@@ -89,7 +89,7 @@
      }

      # Parse the format
-    $format =~ s/%(-*\d*)
+    $format =~ s/%(-?\d*(?:\.\d+)?)
                         ([cCdfFIlLmMnprtxX%])
                         (?:{(.*?)})*/
                         rep($self, $1, $2, $3);

-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

Re: [log4perl-devel] precision in format specifiers

[Mike S. <msc...@ao...>]

ke...@go... wrote:

> While we're on the subbject of PatternLayout, is there any reason 
> we're not including precision (aka max field width) in the sprintf 
> format specifiers? We can do
>    %20m
> but not
>    %20.20m
>
> and the change is below, shall I put it in?
>
Great idea, sure!

-- 
-- Mike

Mike Schilli
log...@pe...

Re: [log4perl-devel] precision in format specifiers

[Kevin G. <ke...@go...>]

Checked in, with tests.

Mike Schilli wrote:
> ke...@go... wrote:
> 
>> While we're on the subbject of PatternLayout, is there any reason 
>> we're not including precision (aka max field width) in the sprintf 
>> format specifiers? We can do
>>    %20m
>> but not
>>    %20.20m
>>
>> and the change is below, shall I put it in?
>>
> Great idea, sure!
> 


-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217