log4perl-devel

[log4perl-devel] Log::Log4perl 0.23 release on log4perl.sourceforge.net

[<msc...@ao...>]

Hey guys,

Erik's changes are in (with a couple of minor modifications, see below) and I've released 0.23 on the website. Documentation and Changes are also updated. Could you guys please verify it's ok before it's going to CPAN?

Here's the stuff I changed from Erik's patch, Erik please let me know if you're ok with it, we can still change it:

* Added a couple of test cases to t/001Level.t

* I moved your excellent documentation on custom levels and inc/decrementing further down to the "Cool Tricks" section -- log4j harshly depreciates custom levels and therefore we shouldn't point the user to it until the "categories" section explains more standard ways to control the amount
of logging.

* Had to change $Log::... to ${Log::...} somewhere because stupid CVS would expand that to what $Log$ is used for :).

-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

Re: [log4perl-devel] Log::Log4perl 0.23 release on log4perl.sourceforge.net

[Kevin G. <ke...@go...>]

> * Had to change $Log::... to ${Log::...} somewhere because stupid CVS would expand that to what $Log$ is used for :).

I just ran 'cvs admin -ko' on our repository, that turns of the cvs 
keyword substitution on all the files (we're not using $Revision$ or 
anything anywhere, right?) so we shouldn't have this problem any more.


avoiding keyword substitution
http://www.loria.fr/~molli/cvs/doc/cvs_12.html#SEC95

cvs admin:
http://www.loria.fr/~molli/cvs/doc/cvs_16.html#SEC113


I tested it on a fresh checkout and it seems to work fine.  Let me know 
if any problems.




-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

Re: [log4perl-devel] Log::Log4perl 0.23 release on log4perl.sourceforge.net

[Erik W. S. <er...@se...>]

I have some $Id: $'s floating about somewhere. For my own $0.02, I'd 
prefer we just use ${Log:: ...} and keep 'em versus turning off that in 
CVS... as when somebody checks out our code and puts it into their own 
CVS repository, they'll clobber it and never know why.

-e

Kevin Goess wrote:

>
>> * Had to change $Log::... to ${Log::...} somewhere because stupid CVS 
>> would expand that to what $Log$ is used for :).
>
>
> I just ran 'cvs admin -ko' on our repository, that turns of the cvs 
> keyword substitution on all the files (we're not using $Revision$ or 
> anything anywhere, right?) so we shouldn't have this problem any more.
>
>
> avoiding keyword substitution
> http://www.loria.fr/~molli/cvs/doc/cvs_12.html#SEC95
>
> cvs admin:
> http://www.loria.fr/~molli/cvs/doc/cvs_16.html#SEC113
>
>
> I tested it on a fresh checkout and it seems to work fine.  Let me 
> know if any problems.
>
>
>
>

Re: [log4perl-devel] Log::Log4perl 0.23 release on log4perl.sourceforge.net

[Kevin G. <ke...@go...>]

msc...@ao... wrote:
> Hey guys,
> 
> Could you guys please verify it's ok before it's going to CPAN?

We need to apply that patch to fix the timing bug first, it's a heinous 
bug.  I'm pretty sure it's ok, but if somebody could eyeball the timing 
logic (after the patch) in Logger::generate_watch_code() I'd feel better.


-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217