Menu
▾
▴
log4perl-devel
|
From: <msc...@ao...> - 2002-09-24 04:47:41
|
In a message dated Mon, 23 Sep 2002 7:10:44 PM Eastern Standard Time, ke...@go... writes: >I just built a 5.8 (not 5.6.1) with threads and Log4perl tested fine, >I'll do more investigation and let you know. That's good to know -- my suspicion is, though, that it's more Windows- than thread-related. -- Mike ############################ # Mike Schilli # # log...@pe... # # http://perlmeister.com # # log4perl.sourceforge.net # ############################ |
|
From: <msc...@ao...> - 2002-09-25 03:35:35
|
Hi Kevin, thanks for all these fixes, that's wonderful! I've also added a fix via File::Spec->catfile() to work around os-dependent file separators. Regarding the STDERR fix, I still need to look into it, not quite sure why re-opening STDERR is unix-ish. -- -- Mike ############################ # Mike Schilli # # log...@pe... # # http://perlmeister.com # # log4perl.sourceforge.net # ############################ |
|
From: Kevin G. <ke...@go...> - 2002-09-25 04:53:51
|
> Regarding the STDERR fix, I still need to look into it, not quite sure why re-opening STDERR is unix-ish. I utterly apologize, it's not, I just hadn't seen the idiom before. All it needed was a select STDERR; $| = 1; after the open. Is now in cvs. -- Happy Trails . . . Kevin M. Goess (and Anne and Frank) 904 Carmel Ave. Albany, CA 94706 (510) 525-5217 |
|
From: <msc...@ao...> - 2002-09-25 06:04:08
|
In a message dated Wed, 25 Sep 2002 12:10:12 AM Eastern Standard Time, ke...@go... writes: >Mike, your fix to PatternLayout.pm took care of the win32 failure for >022Wrap.t, but it necessitated me backing out my regexing fix to the >other four test scripts Oh, sorry, good catch, thanks! Do you have any open issues left or are we OK to move towards the 0.24beta release? -- -- Mike ############################ # Mike Schilli # # log...@pe... # # http://perlmeister.com # # log4perl.sourceforge.net # ############################ |
|
From: Kevin G. <ke...@go...> - 2002-09-25 15:32:19
|
I do not think I have any open issues left. msc...@ao... wrote: > In a message dated Wed, 25 Sep 2002 12:10:12 AM Eastern Standard Time, ke...@go... writes: > > >>Mike, your fix to PatternLayout.pm took care of the win32 failure for >>022Wrap.t, but it necessitated me backing out my regexing fix to the >>other four test scripts > > > Oh, sorry, good catch, thanks! Do you have any open issues left or are we OK to move towards the 0.24beta release? > -- Happy Trails . . . Kevin M. Goess (and Anne and Frank) 904 Carmel Ave. Albany, CA 94706 (510) 525-5217 |
|
From: Kevin G. <ke...@go...> - 2002-09-24 14:47:26
|
1) First, nice work Mike on making Time::HiRes optional, I just noticed
that.
2) I fired up Log4perl on Win32 perl 5.6.1 (Activestate). Here are all
the modules I had to add, if anyone's curious what our base dependencies
are:
Attribute-Handlers
Params-Validate
Log-Dispatch
Test-Simple
Test-Harness
3) t/010JConsole.t used a call to `touch`, which wasn't causing an error
but I fixed anyway.
4) These guys were looking for '/' as a directory separator in their
test results, I changed the ok() comparisons to use regexes with a '.'
instead, that'll match unix '/' and dos '\', but I think a mac is '::'.
There doesn't seem to be an easy way to get the directory separator on
the current machine, anybody know one?
003Layout.t
005Config-Perl.t
006Config-Java.t
007LogPrio.t
(changes checking in now)
5) 020Easy.t is using a unixism to capture STDERR, we need a different
way to test that, but I'm out of time right now
# Test 3 got: '' (t\020Easy.t at line 37)
# Expected: 'm#this we want#'
not ok 4
# Test 4 got: '' (t\020Easy.t at line 38)
# Expected: 'm#this also#'
FAILED tests 3-4
Failed 2/4 tests, 50.00% okay
6) 022Wrap.t I think is showing the %F{1} doesn't work with the windows
'\', but I don't have time to take it further right now.
# Test 1 got: 'File: t\022Wrap.t Line number: 60 package: main'
(t\022Wrap.t at
line 62)
# Expected: 'File: 022Wrap.t Line number: 60 package: main'
FAILED test 1
msc...@ao... wrote:
>
> In a message dated Mon, 23 Sep 2002 7:10:44 PM Eastern Standard Time, ke...@go... writes:
>
> >I just built a 5.8 (not 5.6.1) with threads and Log4perl tested fine,
> >I'll do more investigation and let you know.
>
> That's good to know -- my suspicion is, though, that it's more Windows- than thread-related.
>
> -- Mike
>
> ############################
> # Mike Schilli #
> # log...@pe... #
> # http://perlmeister.com #
> # log4perl.sourceforge.net #
> ############################
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> log4perl-devel mailing list
> log...@li...
> https://lists.sourceforge.net/lists/listinfo/log4perl-devel
--
Happy Trails . . .
Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA 94706
(510) 525-5217
|
|
From: Mark B. <md...@ji...> - 2002-09-24 18:38:42
|
>> On Tue, 24 Sep 2002 07:46:28 -0700,
>> Kevin Goess(KG) wrote:
KG> 4) These guys were looking for '/' as a directory separator in their
KG> test results, I changed the ok() comparisons to use regexes with a '.'
KG> instead, that'll match unix '/' and dos '\', but I think a mac is '::'.
KG> There doesn't seem to be an easy way to get the directory separator on
KG> the current machine, anybody know one?
I'm not sure of the context, but wouldn't File::Spec work? I believe
it is part of the baseline,
File::Spec - portably perform operations on file names
--
-mb-
|
|
From: Kevin G. <ke...@go...> - 2002-09-25 05:11:08
|
Mike, your fix to PatternLayout.pm took care of the win32 failure for
022Wrap.t, but it necessitated me backing out my regexing fix to the
other four test scripts, since the presence of the backslash in the
regex in the ok() calls fubared them.
So all the win32 issues seem to be ok, at least on my activestate 5.6.1.
> 4) These guys were looking for '/' as a directory separator in their
> test results, I changed the ok() comparisons to use regexes with a '.'
> instead, that'll match unix '/' and dos '\', but I think a mac is '::'.
> There doesn't seem to be an easy way to get the directory separator on
> the current machine, anybody know one?
> 003Layout.t
> 005Config-Perl.t
> 006Config-Java.t
> 007LogPrio.t
> (changes checking in now)
>
> 6) 022Wrap.t I think is showing the %F{1} doesn't work with the windows
> '\', but I don't have time to take it further right now.
> # Test 1 got: 'File: t\022Wrap.t Line number: 60 package: main'
> (t\022Wrap.t at
> line 62)
> # Expected: 'File: 022Wrap.t Line number: 60 package: main'
> FAILED test 1
--
Happy Trails . . .
Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA 94706
(510) 525-5217
|
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X