log4cpp CodeGit changes

ChangeLog, index.html

Alexander Perepelkin — Mon, 30 Mar 2026 10:27:09 -0000

ChangeLog, index.html
View Changes

NTEventLogAppender:

Alexander Perepelkin — Mon, 30 Mar 2026 10:27:09 -0000

NTEventLogAppender: * check values returned by winapi functions * print debug messages from NTEventLogAppender constructor onto console only in debug mode * enable use of automatic priorities count to other compilation modules
View Changes

NTEventLogAppender:

Alexander Perepelkin — Mon, 30 Mar 2026 10:27:09 -0000

NTEventLogAppender: * Generate Event Message File "NTEventLogAppender.dll" for Windows Event Viewer with CMake on Win32 platforms. * Message Text File "NTEventLogCategories.mc" is a copy of same file from MSVC projects (plus added trace level) * NTEventLogDummy.cpp is CMake's requirement, source file should be present for the target library
View Changes

NTEventLogAppender:

Alexander Perepelkin — Mon, 30 Mar 2026 10:27:09 -0000

NTEventLogAppender: * Nulling a handle since close() is public method and might be called on already closed appender. * Removed auxiliary functions from the interface and isolated them in implementation. This avoids probable UNICODE related linking issues. * Kept macro-dependant type TCHAR within implementation so that the library is able to respect value of UNICODE definition at compilation time. Thanks to Jac Goudsmit for noticing and proposals. * Fix probable out-of-bounds errors.
View Changes

ChangeLog

Alexander Perepelkin — Fri, 27 Mar 2026 19:43:56 -0000

ChangeLog
View Changes

Merge Request #7 of Log library for C++:codegit.git discussion

Alexander Perepelkin — Fri, 27 Mar 2026 19:35:52 -0000

Status: open --> merged

Merge Request #7 of Log library for C++:codegit.git discussion

Alexander Perepelkin — Fri, 27 Mar 2026 19:35:24 -0000

Summing comments on commits in merge request and my replies:

close() now resets _hEventSource to NULL to prevent dangling handle

close() is either the last action performed by the class in destructor, or the action which is immediately followed by the open() and rewites handle right away. Hence, though nulling it might look like a proper precaution, it is redundant.

Functions that use _hEventSource now check for the handle to be non-NULL before using it (prevents invalid parameter exceptions in recent versions of Windows)

Added a check for empty _strSourceName to open()

Having checks in functions open() and _append() would hide mistaken parameters instead of raising errors.
If _strSourceName is empty, it most probably means that this is a mistake and it should be caught and fixed during testing (instead of being hidden behind a check)

The old open() function was only safe to call when the appender is in closed state, otherwise it would leak a handle.

open() is protected and can not be called by clients of the class. Other calls are controlled by the implementation and those do not leak a handle.

Therefore it made sense to move the functionality of the open() function to the reopen() function <...>

That would mix semantics of open/reopen, making implementation more complex than it can be.

The old version of addRegistryInfo would always use "NTEventLogAppender.dll" without drive or directory, so it was necessary to put the DLL in the PATH or change the PATH to add the directory where the DLL is stored
Finally, the protected registry functions used TCHAR in their prototypes, which is a very bad idea: programs that are compiled in Unicode and use these functions would be incompatible with the log4cpp.dll because the DLL and the program would disagree on what a TCHAR is. This results in linker problems that are potentially very difficult or impossible to debug, especially for beginning Windows programmers.
Another problem was that the reopen() function would always get the registry key to check if it existed, which should not be necessary in most cases. And if the registry key already existed, the function wouldn't save the values so it was impossible to deliberately change the values.

These are all good points and could be fixed independently. Unfortunately, current merge request takes care of all of them together and they are now on top of another changes.
Rewriting registry keys on each reopen() call is solved by moving addRegistryInfo() invokation into constructor. That way multiple reopen() calls will not cause many cycles of equivalent writes to registry.
Other two points can be considered as a list of good items to do.

Avoid calling virtual functions from constructor: make open() non-virtual to remove ambiguity.

Alexander Perepelkin — Fri, 27 Mar 2026 19:28:24 -0000

Avoid calling virtual functions from constructor: make open() non-virtual to remove ambiguity.
View Changes

NTEventLogAppender:

Alexander Perepelkin — Fri, 27 Mar 2026 19:28:24 -0000

NTEventLogAppender: * fix for bug #148: remove virtual from open(). * avoid calling addRegistryInfo() on each invocation of reopen(), call it once in ctr instead. Thanks to Jac Goudsmit for reporting and proposals.
View Changes

Changelog

Alexander Perepelkin — Thu, 26 Mar 2026 19:14:10 -0000

Changelog index.html Refine text, add entries to FAQ, add changelog
View Changes