Re: [Log4cplus-devel] log4cplus // source locality

[Sergei N. <ser...@gm...>]

2017-07-26 14:37 GMT+03:00 Václav Haisman <vha...@gm...>:
> On 26 July 2017 at 12:21, Sergei Nikulov wrote:
>> Hello Václav,
>>
>> What I liked about 1.x.x - possibility to use it without any links to
>> GitHub from the local clone.
>> But times flies and I try to use 2.x.x in my project (new compilers
>> complains too much about auto_ptr).
>>
>> On 2.x.x branch you've added submodules for catch and threadpool.
>>
>> Is it possible not using submodules in 2.x.x line?
>> Was it some unresolvable requirement to add those links?
>>
>> Thank you.
>
> I have added the submodules because that allows me to update them
> without much hassle that in-tree maintenance of imported sources would
> bring. Threadpool is required so that all logging requests can be
> handled asynchronously. Catch is required for unit tests
> implementation.
>
> What is your objection to using submodules?

I prefer have self-contained sources, without any links to external
repositories.
The only objection - I need a live internet connection to GitHub even
if I clone log4cplus from local folder/mirror.

It is no big deal, but it complicates things a bit for only 2 files added.

Catch can be added without any issues as a single file (or even
downloaded when tests enabled).
Threadpool also not changed since 2015, so can be "frozen" within the
repository.

>
> --
> VH



-- 
Best Regards,
Sergei Nikulov