[Log4cplus-devel] [ log4cplus-Bugs-3584858 ] Issues with MinGW and v1.1.0

[SourceForge.net <no...@so...>]

Bugs item #3584858, was opened at 2012-11-06 13:24
Message generated for change (Comment added) made by csteenwyk
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=429073&aid=3584858&group_id=40830

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Chris Steenwyk (csteenwyk)
Assigned to: Václav Zeman (wilx)
Summary: Issues with MinGW and v1.1.0

Initial Comment:
I ran into some issues compiling the latest code with mingw.  I've included a patch file to show the differences, though I am running it off a different SVN so it won't merge in correctly with the log4cplus trunk.

Anyway, my issues:

The define LOG4CPLUS_HAVE_INTRIN_H includes a header that isn't included in mingw (intrin.h). So I removed including that header as part of mingw.

The function LockFile::open (int open_flags) calls _tsopen_s which is not part of mingw. I modified this function to switch on the UNICODE define and call _wsopen or _sopen.

----------------------------------------------------------------------

>Comment By: Chris Steenwyk (csteenwyk)
Date: 2012-11-07 06:00

Message:
It looks like the 64-bit version defines both __MINGW64__ AND __MINGW32__
where the 32-bit version only defines __MINGW32__

So I think for the 64-bit specific stuff we could use __MINGW64__, and for
all other mingw specific stuff we could use __MINGW32__

----------------------------------------------------------------------

Comment By: Václav Zeman (wilx)
Date: 2012-11-06 13:51

Message:
Thank you for the patch. You seem to be using MinGW32 distribution. Is this
correct? The intrin.h header is present in MinGW64 distribution that I am
using. Also the *_s() functions are present there. I wonder if there is not
some preprocessor symbol that could help to distinguish these two
compilers/distributions.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=429073&aid=3584858&group_id=40830