[Log4cplus-devel] [ log4cplus-Bugs-3174236 ] Compilation of liblog4cplus 1.0.5 (HEAD) failed on Solaris 8

[SourceForge.net <no...@so...>]

Bugs item #3174236, was opened at 2011-02-06 07:25
Message generated for change (Settings changed) made by wilx
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=429073&aid=3174236&group_id=40830

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: v1.1.x
Status: Pending
Resolution: Accepted
>Priority: 4
Private: No
Submitted By: Mikael Tintinger (mtintinger)
Assigned to: Václav Zeman (wilx)
Summary: Compilation of liblog4cplus 1.0.5 (HEAD) failed on Solaris 8

Initial Comment:
libtool: compile:  CC -DHAVE_CONFIG_H -DINSIDE_LOG4CPLUS -I../include -I../include -DNDEBUG -DUNICODE -D_REENTRANT -g +w -library=stlport4 -library=Crun -D_REENTRANT -c stringhelper.cxx  -KPIC -DPIC -o .libs/stringhelper.o
"stringhelper.cxx", line 360: Error: towupper is not a member of file level.
"stringhelper.cxx", line 378: Error: towlower is not a member of file level.

To build the library I have to launch ./configure CFLAGS=-DUNICODE CPPFLAGS=-DUNICODE
and include <wchar.h> for towupper and towlower functions in stringhelper.cxx.

Is it possible to make UNICODE an option as it is for REENTRANT (enable-threads) ?


----------------------------------------------------------------------

Comment By: Václav Zeman (wilx)
Date: 2012-09-03 22:33

Message:
Is this fixed for you in the 1.1.0 series?

----------------------------------------------------------------------

Comment By: Václav Zeman (wilx)
Date: 2011-02-06 13:31

Message:
As for the -DUNICODE, I have thought about it in the past and I have
decided not to do it. You might want to use single copy of headers with
separate binaries for both wchar_t and char versions of the library. The
REENTRANT define does not leak into the user space, its situation is
slightly different.

----------------------------------------------------------------------

Comment By: Václav Zeman (wilx)
Date: 2011-02-06 13:27

Message:
Hmm. I think that what needs changing are the bodies of toupper_func and
tolower_func, removing the inner #ifdef. I have committed the change in
revision 1521. Please try to compile it now.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=429073&aid=3174236&group_id=40830