Re: [Log4cplus-devel] 1.1.0 compatible with 1.0.4

[Václav Z. <vha...@gm...>]

On 2 August 2012 10:52, Václav Zeman wrote:
> On 1 August 2012 16:07, Jeremy C. Reed wrote:
>> I didn't see any release notes in 1.1.0-RC6 (sorry I didn't try RC7 yet)
>> about any incompatibilities with 1.0.4.  Will there be any notes about
>> it or upgrade hints?  We want to support both versions.
> Even though it is not stated anywhere, my intention has always been to
> keep only source compatibility between versions.
>
>>
>> For example, to support two versions we have:
>>
>> #if (LOG4CPLUS_VERSION >= LOG4CPLUS_MAKE_VERSION(1, 1, 0))
>>     typedef log4cplus::tstring const & LogLevelString;
>> #else
>>     typedef log4cplus::tstring LogLevelString;
>> #endif
> I have seen the other email from John Lumby. While the change in the
> return type is intentional, I did not realize it would create this
> incompatibility. I guess that the onus is on log4cplus to fix this and
> provide a compatible interface. I will try to think of something.

One another source of incompatibility between 1.0.x and 1.1.x is the
return type of helpers::LogLog::getLogLog(). It is supposed to be used
only internally by log4cplus but it is part of public interface as
well. Its return type has changed from SharedObjectPtr<LogLog> to
LogLog *. Work around for this is not to try to cache the value
returned by helpers::LogLog::getLogLog() in a variable.

-- 
VZ