Re: [Log4cplus-devel] log4cplus 1.0.4-RC10 released

[Hannah S. <han...@1u...>]

Hi!

On Sun, Jul 18, 2010 at 12:22:12PM +0200, Václav Haisman wrote:
>I have removed the %X{N} PatternLayout format specifier introduced in
>previous RC because conflicts with PatternLayout format specifier for MDC,
>which has been added to trunk in the repository.

I see the point of freeing %X for MDC. However, do I see things right
that using a property for an NDC depth limit means that things are more
"global"?

With a format parameter (even if it be an optional parameter to %x, the
*existing* NDC converter), you could format the NDC multiple times in a
single format, using *different* limits (e.g. using a tight limit
relatively early in the log line, and using no limit late in the line,
so people reading the log could see the limited NDC at the first glance,
but still the complete NDC is not completely lost). But if I understand
the property thing right, this wouldn't be possible now, as the property
influences NDC formatting in a more "global" way now (at least inside
eacy patternlayout).

>[...]

>Let's hope no more bugs will crop up and that this will really be the last
>release candidate for log4cplus 1.0.4. :)

I see a long standing coding bug in src/configurator.cxx, in line 729 of
PRODUCTION_1_0_x r1434. Here, the lstat() return status isn't checked,
which might cause unexpected function results if the filename checked
denotes a broken symbolic link.

Kind regards,

Hannah.