[Log4cplus-devel] Rest of the patches (was Re: log4cplus 1.0.4-RC8 released)

[Hannah S. <han...@1u...>]

Hi!

On Wed, Jun 02, 2010 at 12:01:33AM +0200, Václav Haisman wrote:
>[...]

>Yes, I will consider any patches you send.

>[...]

>The best for me is if you base the patches on the HEAD revision of e.g.
>PRODUCTION_1_0_x branch. But it does not matter much, I can deal with patches
>against release source as well.

No problem, rebasing them wasn't difficult.

>> Based on your feedback, I could send you the other patches which would
>> encompass another fix for a possible problem we noticed here in our
>> company, and a few feature additions we've come to depend upon here.

>Please send the patches. I will consider each one of them separately. Use
>either the mailing list or the patches tracker on SF, whichever is more
>comfortable.

Sending them here.

Little explanations.

0001 seems to fix a bug for the syslog appender in some cases (if either
log4cplus uses wstrings and thus LOG4CPLUS_TSTRING_TO_STRING returns a
temporary, or the identifier is derived from a property, so the
identifier is always a temporary). At least glibc always stores the
char* you pass it, instead of copying it by itself.

0002 is a feature addition we needed in house. log4cplus already
supports logging of the thread ID returned by pthread_self, however, for
us that wasn't as useful as the gettid() id, as they're different and ps
shows only the latter (Linux uses 1:1 threading).

0003 is a feature addition analogous to acces the behavior of
openlog itself, namely being able to pass the NULL pointer to openlog to
access a default.

0004 makes the syslog *facility* configurable, instead of only being
able to use the default (LOG_USER).

0005 makes it possible to limit the depth of the NDC in the pattern
layout.

Kind regards,

Hannah.