Bugs item #3165465, was opened at 2011-01-25 11:44
Message generated for change (Comment added) made by wilx
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=429073&aid=3165465&group_id=40830
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
>Group: v1.1.x
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: rjmyst3 (rjmyst3)
Assigned to: Václav Zeman (wilx)
Summary: please avoid windows.h in header files
Initial Comment:
Thank you very much for an excellent logging library. It is working very well for us, and we appreciate all the time you spend on it.
One problem that we are having is that windows.h is included indirectly via logger.h->config.hxx->thread-config.h
windows.h is a nasty header to impose on all users of logger.h and causes lots of problems.
Here are some examples of the problems that it causes:
Boost: https://svn.boost.org/trac/boost/ticket/1740
wxWidgets: "The windows.h Header File, Macros and Compiling Errors" http://wiki.wxwidgets.org/WxMSW_Issues#The_windows.h_Header_File.2C_Macros_and_Compiling_Errors
StackOverflow: http://stackoverflow.com/questions/4111899/is-there-an-easy-one-shot-solution-to-the-preprocessor-namespace-pollution-introd
Please create an abstraction layer that hides the use of windows.h from users of logger.h
----------------------------------------------------------------------
>Comment By: Václav Zeman (wilx)
Date: 2012-08-31 05:14
Message:
At this point in time I would suggest switching to 1.1.0-RC8. I am closing
this as fixed.
----------------------------------------------------------------------
Comment By: rjmyst3 (rjmyst3)
Date: 2011-04-11 05:48
Message:
I'm glad that you've already solved this in trunk.
We are really struggling to add log4cplus to our wxWidgets projects right
now. Is there a stable revision of trunk that we could switch to? What do
you recommend?
----------------------------------------------------------------------
Comment By: Václav Zeman (wilx)
Date: 2011-01-25 13:08
Message:
I have already hidden windows.h from public headers on SVN trunk. I will
try to port the changes back to the 1.0.x branch for 1.0.5. Thank you for
the bug report.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=429073&aid=3165465&group_id=40830
|
