log4cplus / Bugs / #306 Extend ServerSocket to be able to specify host to bind to

Václav Haisman - 2014-06-24

assigned_to: Václav Zeman
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Václav Haisman - 2014-06-29

labels: --> patch, socket

Group: v1.1.2 --> future
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -2,11 +2,13 @@

 We are using your lib for our internal purposes and have faced with the following issue: 

-we use ServerSocket class to receive log events through network. But we need to restrict address our tool should bind to. Currently ServerSocket uses:
+We use `ServerSocket` class to receive log events through network. But we need to restrict address our tool should bind to. Currently `ServerSocket` uses:

+~~~~{.c}
 server.sin_family = AF_INET;
 server.sin_addr.s_addr = INADDR_ANY;
 server.sin_port = htons(port);
+~~~~

 only port can be specified.

Václav Haisman - 2014-06-29

Rather than creating a new socket class, it would be nice to improve the existing one. It would help if you posted a complete and testable patch.

Last edit: Václav Haisman 2014-06-29

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Maxim Kondratenko - 2014-07-08

Hello,

please consider the new version in the attach. Unfortunately I do not have Windows host for developing thus I adjusted only socket-unix.cxx.

ServerSocket.patch.tar.gz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Václav Haisman - 2014-07-08

Group: future --> v1.2.0

Priority: 5 --> 6
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Maxim Kondratenko - 2016-03-15

Hello,
Is there any progress on this matter?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Václav Haisman - 2016-03-15

I have applied a patch in the spirit of your patch onto master. I will take a look if I can easily transplant it also to 1.2.x. I am not sure if I will be adding it to 1.1.x at all.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Maxim Kondratenko - 2016-06-23
  
  I don't mind against adding this patch to 1.2 version.
  
  Last edit: Maxim Kondratenko 2016-06-23
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Extend ServerSocket to be able to specify host to bind to

Logging Framework for C++

Group

Searches

Help

#306 Extend ServerSocket to be able to specify host to bind to

Discussion