[lobby-svn] SF.net SVN: lobby:[1035] trunk/src_server/net/yura/lobby/server

[<yu...@us...>]

Revision: 1035
          http://sourceforge.net/p/lobby/code/1035
Author:   yuranet
Date:     2023-05-05 20:06:24 +0000 (Fri, 05 May 2023)
Log Message:
-----------
better error for session not logged in

Modified Paths:
--------------
    trunk/src_server/net/yura/lobby/server/GameLobby.java
    trunk/src_server/net/yura/lobby/server/LobbyController.java

Modified: trunk/src_server/net/yura/lobby/server/GameLobby.java
===================================================================
--- trunk/src_server/net/yura/lobby/server/GameLobby.java	2023-04-15 14:14:08 UTC (rev 1034)
+++ trunk/src_server/net/yura/lobby/server/GameLobby.java	2023-05-05 20:06:24 UTC (rev 1035)
@@ -993,10 +993,15 @@
     }
 
     private User getUser(LobbySession session) {
-        User user = database.getUserByUsername(session.getUsername());
-        if (user==null) {
-            throw new IllegalArgumentException("no user for " + session.getUsername());
+        String username = session.getUsername();
+        if (username == null) {
+            throw new IllegalArgumentException("this session is not logged in yet: " + session);
         }
+
+        User user = database.getUserByUsername(username);
+        if (user == null) {
+            throw new IllegalArgumentException("no user for: " + username);
+        }
         return user;
     }
     private GameRoom getGame(int id) {

Modified: trunk/src_server/net/yura/lobby/server/LobbyController.java
===================================================================
--- trunk/src_server/net/yura/lobby/server/LobbyController.java	2023-04-15 14:14:08 UTC (rev 1034)
+++ trunk/src_server/net/yura/lobby/server/LobbyController.java	2023-05-05 20:06:24 UTC (rev 1035)
@@ -491,8 +491,13 @@
 
 
 
+/**
+ * This encryption ONLY protects against packet sniffers finding out the content of the encrypted data
+ * it does NOT:
+ *   1) prevent man in the middle, where the attacker sends there own private key
+ *   2) prevent already encrypted data being re-sent to authenticate on the server
+ */
 
-
     private static KeyPairGenerator kpg;
     private static RSAPrivateKey privKey;
     private static RSAPublicKey pubKey;

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.