From: Robert J. <spa...@gm...> - 2012-07-08 19:05:22
|
Hi, Some bugs in 2.0 Making some recordings here, found a pecular bug. Moving an effect in the plugin rack causes parameter editing to go haywire. Most seem to be reset to 0 and many are not possible to change after that even though the track has automation OFF. Also as reported by Pavel Fric, the right click menu with the editor tools is not possible to translate, it doesn't use tr() but the TR_something_NOOP macro, something to do with that I guess... There are some texts in the file dialog that also are not translatable, seem to be inherited from the Qt component, wierd that they don't obey translation, or maybe it's just that we don't have the string.. /Robert |
From: Tim E. R. <ter...@ro...> - 2012-07-08 20:29:38
|
On July 8, 2012 9:05:15 PM Robert Jonsson wrote: > Hi, > > Some bugs in 2.0 > > Making some recordings here, found a pecular bug. Moving an effect in > the plugin rack causes parameter editing to go haywire. Most seem to > be reset to 0 and many are not possible to change after that even > though the track has automation OFF. Sounds like my department. Some changes there recently. Will check. Tim. > > Also as reported by Pavel Fric, the right click menu with the editor > tools is not possible to translate, it doesn't use tr() but the > TR_something_NOOP macro, something to do with that I guess... > There are some texts in the file dialog that also are not > translatable, seem to be inherited from the Qt component, wierd that > they don't obey translation, or maybe it's just that we don't have the > string.. > > /Robert > > ---------------------------------------------------------------------------- > -- Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Lmuse-developer mailing list > Lmu...@li... > https://lists.sourceforge.net/lists/listinfo/lmuse-developer |
From: Tim E. R. <ter...@ro...> - 2012-07-12 02:49:00
|
On July 8, 2012 4:29:20 PM Tim E. Real wrote: > On July 8, 2012 9:05:15 PM Robert Jonsson wrote: > > Hi, > > > > Some bugs in 2.0 > > > > Making some recordings here, found a pecular bug. Moving an effect in > > the plugin rack causes parameter editing to go haywire. Most seem to > > be reset to 0 and many are not possible to change after that even > > though the track has automation OFF. > > Sounds like my department. Some changes there recently. Will check. > Tim. Crud. I broke it. As usual. I wanted to override class CtrlList's insert, erase, clear, operator= etc. so that I could absolutely catch all operations requiring gui updates, so that I wouldn't have to hunt down every last piece of code using them and manually add a gui update command. It worked sort of: My override of map::operator= is not working. None of the members are being transferred. Declaration: =================== class CtrlList : public std::map<int, CtrlVal, std::less<int> > { ... CtrlList& operator=(const CtrlList&); ... } Definition: ==================== CtrlList& CtrlList::operator=(const CtrlList& cl) { // // THIS CALL IS NOT WORKING. HELP - HOW TO DO IT? // std::map<int, CtrlVal, std::less<int> >::operator=(cl); ... } How can I call the base (std::map) class's operator= ? I tried several variations of the above line but no luck. It works if I remove my entire overriding method and let std::map do the work. Also I thought that adding these overrides would ultimately actually /allow/ me to hunt down every piece of code using them and then remove these overrides. Almost, but not with operator= : KDevelop does not show me usages such as here (which is where the swapping of rack items happens): audiotrack.cpp : AudioTrack::swapControllerIDX() { ... newcl = new CtrlList(); *newcl = *cl; ... } And yet my operator= routine is in fact called there. Any suggestions? Tim. > > > Also as reported by Pavel Fric, the right click menu with the editor > > tools is not possible to translate, it doesn't use tr() but the > > TR_something_NOOP macro, something to do with that I guess... > > There are some texts in the file dialog that also are not > > translatable, seem to be inherited from the Qt component, wierd that > > they don't obey translation, or maybe it's just that we don't have the > > string.. > > > > /Robert > > |
From: Florian J. <flo...@we...> - 2012-07-12 06:46:18
Attachments:
signature.asc
|
Am 12.07.2012 04:48, schrieb Tim E. Real: > On July 8, 2012 4:29:20 PM Tim E. Real wrote: >> On July 8, 2012 9:05:15 PM Robert Jonsson wrote: >>> Hi, >>> >>> Some bugs in 2.0 >>> >>> Making some recordings here, found a pecular bug. Moving an effect in >>> the plugin rack causes parameter editing to go haywire. Most seem to >>> be reset to 0 and many are not possible to change after that even >>> though the track has automation OFF. >> >> Sounds like my department. Some changes there recently. Will check. >> Tim. > > Crud. I broke it. As usual. > > I wanted to override class CtrlList's insert, erase, clear, operator= etc. > so that I could absolutely catch all operations requiring gui updates, > so that I wouldn't have to hunt down every last piece of code using them > and manually add a gui update command. > > It worked sort of: > > My override of map::operator= is not working. None of the members are > being transferred. > > Declaration: > =================== > class CtrlList : public std::map<int, CtrlVal, std::less<int> > { > ... > CtrlList& operator=(const CtrlList&); > ... > } > > Definition: > ==================== > CtrlList& CtrlList::operator=(const CtrlList& cl) > { > // > // THIS CALL IS NOT WORKING. HELP - HOW TO DO IT? > // > std::map<int, CtrlVal, std::less<int> >::operator=(cl); > > ... > } > > How can I call the base (std::map) class's operator= ? > > I tried several variations of the above line but no luck. > It works if I remove my entire overriding method and let > std::map do the work. > > Also I thought that adding these overrides would ultimately actually > /allow/ me to hunt down every piece of code using them and then > remove these overrides. > Almost, but not with operator= : > KDevelop does not show me usages such as here (which is where the > swapping of rack items happens): > > audiotrack.cpp : AudioTrack::swapControllerIDX() > { > ... > newcl = new CtrlList(); > *newcl = *cl; > ... > } > > And yet my operator= routine is in fact called there. > > Any suggestions? is the function called at all? maybe some casting issue between map and CtrlList? though i actually would like to find the mistake, as an (even cleaner) workaround you could make CtrlList not derive from map, but _contain_ a map instead, and then "forward" most function calls. this ensures nobody can call a map's member you haven't thought of and thus not overridden. greetings flo > > Tim. > >> >>> Also as reported by Pavel Fric, the right click menu with the editor >>> tools is not possible to translate, it doesn't use tr() but the >>> TR_something_NOOP macro, something to do with that I guess... >>> There are some texts in the file dialog that also are not >>> translatable, seem to be inherited from the Qt component, wierd that >>> they don't obey translation, or maybe it's just that we don't have the >>> string.. >>> >>> /Robert >>> > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Lmuse-developer mailing list > Lmu...@li... > https://lists.sourceforge.net/lists/listinfo/lmuse-developer > |
From: Tim E. R. <ter...@ro...> - 2012-07-12 07:17:47
|
On July 11, 2012 10:48:36 PM Tim E. Real wrote: > On July 8, 2012 4:29:20 PM Tim E. Real wrote: > > On July 8, 2012 9:05:15 PM Robert Jonsson wrote: > > > Hi, > > > > > > Some bugs in 2.0 > > > > > > Making some recordings here, found a pecular bug. Moving an effect in > > > the plugin rack causes parameter editing to go haywire. Most seem to > > > be reset to 0 and many are not possible to change after that even > > > though the track has automation OFF. > > > > Sounds like my department. Some changes there recently. Will check. > > Tim. > > Crud. I broke it. As usual. > > I wanted to override class CtrlList's insert, erase, clear, operator= etc. > so that I could absolutely catch all operations requiring gui updates, > so that I wouldn't have to hunt down every last piece of code using them > and manually add a gui update command. > > It worked sort of: > > My override of map::operator= is not working. None of the members are > being transferred. > > Declaration: > =================== > class CtrlList : public std::map<int, CtrlVal, std::less<int> > { > ... > CtrlList& operator=(const CtrlList&); > ... > } > > Definition: > ==================== > CtrlList& CtrlList::operator=(const CtrlList& cl) > { > // > // THIS CALL IS NOT WORKING. HELP - HOW TO DO IT? > // > std::map<int, CtrlVal, std::less<int> >::operator=(cl); > > ... > } > > How can I call the base (std::map) class's operator= ? > > I tried several variations of the above line but no luck. > It works if I remove my entire overriding method and let > std::map do the work. I just realized the base operator knows nothing of our derived class members (I believe it will copy the items, though), so I think I must manually copy them in this case. For which we do have an assign() member, so I could use that. Will test and fix ASAP. Tim. > > Also I thought that adding these overrides would ultimately actually > /allow/ me to hunt down every piece of code using them and then > remove these overrides. > Almost, but not with operator= : > KDevelop does not show me usages such as here (which is where the > swapping of rack items happens): > > audiotrack.cpp : AudioTrack::swapControllerIDX() > { > ... > newcl = new CtrlList(); > *newcl = *cl; > ... > } > > And yet my operator= routine is in fact called there. > > Any suggestions? > > Tim. > > > > Also as reported by Pavel Fric, the right click menu with the editor > > > tools is not possible to translate, it doesn't use tr() but the > > > TR_something_NOOP macro, something to do with that I guess... > > > There are some texts in the file dialog that also are not > > > translatable, seem to be inherited from the Qt component, wierd that > > > they don't obey translation, or maybe it's just that we don't have the > > > string.. > > > > > > /Robert > |
From: Orcan O. <oge...@gm...> - 2012-07-12 12:03:33
|
On Wed, Jul 11, 2012 at 10:48 PM, Tim E. Real wrote: > On July 8, 2012 4:29:20 PM Tim E. Real wrote: >> On July 8, 2012 9:05:15 PM Robert Jonsson wrote: >> > Hi, >> > >> > Some bugs in 2.0 >> > >> > Making some recordings here, found a pecular bug. Moving an effect in >> > the plugin rack causes parameter editing to go haywire. Most seem to >> > be reset to 0 and many are not possible to change after that even >> > though the track has automation OFF. >> >> Sounds like my department. Some changes there recently. Will check. >> Tim. > > Crud. I broke it. As usual. > > I wanted to override class CtrlList's insert, erase, clear, operator= etc. > so that I could absolutely catch all operations requiring gui updates, > so that I wouldn't have to hunt down every last piece of code using them > and manually add a gui update command. > > It worked sort of: > > My override of map::operator= is not working. None of the members are > being transferred. > > Declaration: > =================== > class CtrlList : public std::map<int, CtrlVal, std::less<int> > { > ... > CtrlList& operator=(const CtrlList&); > ... > } > > Definition: > ==================== > CtrlList& CtrlList::operator=(const CtrlList& cl) > { > // > // THIS CALL IS NOT WORKING. HELP - HOW TO DO IT? > // > std::map<int, CtrlVal, std::less<int> >::operator=(cl); > > ... > } > > How can I call the base (std::map) class's operator= ? > 2 suggestions: It may be a compiler issue. Did you try another compiler, e.g. clang? Also I would try typedef'ing the parent class. For some reason I keep having problems for deriving from template classes too, and typedefs help for some reason. Cheers, Orcan |
From: Tim E. R. <ter...@ro...> - 2012-07-13 08:05:25
|
On July 8, 2012 4:29:20 PM Tim E. Real wrote: > On July 8, 2012 9:05:15 PM Robert Jonsson wrote: > > Hi, > > > > Some bugs in 2.0 > > > > Making some recordings here, found a pecular bug. Moving an effect in > > the plugin rack causes parameter editing to go haywire. Most seem to > > be reset to 0 and many are not possible to change after that even > > though the track has automation OFF. > > Sounds like my department. Some changes there recently. Will check. > Tim. OK Fixed now in trunk. - Fixed controllers go wacky after moving effects rack plugins up/down. My bad! Rewrote CtrlList::operator= and several others. Tested OK. - Also fixed existing problem: After moving rack plugins up/down, graphs disappear. Simple oversight in AudioTrack::swapControllerIDX: New members 'color', 'visible', and 'don't show' weren't being copied. - Documentation: Some contributions to the documentation.tex file. *** Also, I merged everything from trunk revision 1558 back into the release_2_0 branch, starting with Robert's list edit 'inc/dec' additions, but excluding my first new-drum fix after r2_0 in trunk of course. I hope some other stuff like translations were not 'new-drums specific'. If so I'll have to backtrack a bit I guess. Whaddya say we quickly release a bug fix version (or two) while we work in trunk? release_2_0 branch would be ready to go, but can you guys give it the once-over, test it out and make sure it's OK? I've tested it as much as I can and it's good AFAICT. Thanks, and sorry for the breakage RJ ! Tim. > > > Also as reported by Pavel Fric, the right click menu with the editor > > tools is not possible to translate, it doesn't use tr() but the > > TR_something_NOOP macro, something to do with that I guess... > > There are some texts in the file dialog that also are not > > translatable, seem to be inherited from the Qt component, wierd that > > they don't obey translation, or maybe it's just that we don't have the > > string.. > > > > /Robert > > |
From: Robert J. <spa...@gm...> - 2012-07-13 19:53:52
|
2012/7/13 Tim E. Real <ter...@ro...>: > On July 8, 2012 4:29:20 PM Tim E. Real wrote: >> On July 8, 2012 9:05:15 PM Robert Jonsson wrote: >> > Hi, >> > >> > Some bugs in 2.0 >> > >> > Making some recordings here, found a pecular bug. Moving an effect in >> > the plugin rack causes parameter editing to go haywire. Most seem to >> > be reset to 0 and many are not possible to change after that even >> > though the track has automation OFF. >> >> Sounds like my department. Some changes there recently. Will check. >> Tim. > > OK Fixed now in trunk. > > - Fixed controllers go wacky after moving effects rack plugins up/down. > My bad! Rewrote CtrlList::operator= and several others. Tested OK. > - Also fixed existing problem: After moving rack plugins up/down, graphs > disappear. Simple oversight in AudioTrack::swapControllerIDX: New members > 'color', 'visible', and 'don't show' weren't being copied. > - Documentation: Some contributions to the documentation.tex file. > > *** Also, I merged everything from trunk revision 1558 back into the > release_2_0 branch, starting with Robert's list edit 'inc/dec' additions, > but excluding my first new-drum fix after r2_0 in trunk of course. > > I hope some other stuff like translations were not 'new-drums specific'. > If so I'll have to backtrack a bit I guess. I'll check a bit soonish. > > Whaddya say we quickly release a bug fix version (or two) while we > work in trunk? Sounds like a plan I'll try to get it out on sunday. > release_2_0 branch would be ready to go, but can you guys give it > the once-over, test it out and make sure it's OK? > I've tested it as much as I can and it's good AFAICT. Yeah, will try a flyby before releasing. > Thanks, and sorry for the breakage RJ ! No problem! /Robert > Tim. > >> >> > Also as reported by Pavel Fric, the right click menu with the editor >> > tools is not possible to translate, it doesn't use tr() but the >> > TR_something_NOOP macro, something to do with that I guess... >> > There are some texts in the file dialog that also are not >> > translatable, seem to be inherited from the Qt component, wierd that >> > they don't obey translation, or maybe it's just that we don't have the >> > string.. >> > >> > /Robert >> > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Lmuse-developer mailing list > Lmu...@li... > https://lists.sourceforge.net/lists/listinfo/lmuse-developer |
From: Robert J. <spa...@gm...> - 2012-07-17 12:54:06
|
2012/7/13 Robert Jonsson <spa...@gm...>: > 2012/7/13 Tim E. Real <ter...@ro...>: >> On July 8, 2012 4:29:20 PM Tim E. Real wrote: >>> On July 8, 2012 9:05:15 PM Robert Jonsson wrote: >>> > Hi, >>> > >>> > Some bugs in 2.0 >>> > >>> > Making some recordings here, found a pecular bug. Moving an effect in >>> > the plugin rack causes parameter editing to go haywire. Most seem to >>> > be reset to 0 and many are not possible to change after that even >>> > though the track has automation OFF. >>> >>> Sounds like my department. Some changes there recently. Will check. >>> Tim. >> >> OK Fixed now in trunk. >> >> - Fixed controllers go wacky after moving effects rack plugins up/down. >> My bad! Rewrote CtrlList::operator= and several others. Tested OK. >> - Also fixed existing problem: After moving rack plugins up/down, graphs >> disappear. Simple oversight in AudioTrack::swapControllerIDX: New members >> 'color', 'visible', and 'don't show' weren't being copied. >> - Documentation: Some contributions to the documentation.tex file. >> >> *** Also, I merged everything from trunk revision 1558 back into the >> release_2_0 branch, starting with Robert's list edit 'inc/dec' additions, >> but excluding my first new-drum fix after r2_0 in trunk of course. >> >> I hope some other stuff like translations were not 'new-drums specific'. >> If so I'll have to backtrack a bit I guess. > > I'll check a bit soonish. >> >> Whaddya say we quickly release a bug fix version (or two) while we >> work in trunk? > > Sounds like a plan I'll try to get it out on sunday. this didn't really work out, because of... reasons. But I'm working on it. /Robert |