Menu

#75 1.3.1 aborts when asked for hashset of unknown file

open
nobody
None
5
2003-06-24
2003-06-24
Anonymous
No

lmule-1.3.1 does handle requests for a hashset in
CUpDownClient::SendHashsetPacket(). If there is no such
file it does throw an exception. This exception is not
handled and due the program does abort.

I made a work-arround which seems to work for me but am
not sure it is correct in means of the protocol. (See
appended patch.) Maybe it would be better to send no
answer et all in this case.

Michael

Discussion

  • Nobody/Anonymous

    my work-arround (patch)

     
  • Michael Mueller

    Michael Mueller - 2003-06-24

    Logged In: YES
    user_id=34877

    On further look it seems to be a general problem with
    exception handling. Most of the source code is from the
    original eMule client. It throws CString objects quite
    often. Due to the usage of wxWindows those throws now throw
    wxString objects in lmule, which are never catched.

     
  • Ingo Schmiegel

    Ingo Schmiegel - 2003-07-04

    Logged In: YES
    user_id=328377

    I had the same problem. The workaround/patch by Michael
    seems to work. Without the patch I got the crash about every
    20 minutes, once being connected to a server. With the patch
    lmule runs fine now for more than a day.
    However, I agree with user malware that most likely the
    exception code needs a rework instead of muddling on...

     
  • Ted R. Smith

    Ted R. Smith - 2003-07-06

    Logged In: YES
    user_id=23127

    yes this problem was fixed *LONG* ago by myself.
    1st, upgrade to xMule, the continuation of LMule , via http:
    //www.xmule.org.
    2nd, if the problem still exists, see http://www.xmule.
    org/forums for details.

     

Log in to post a comment.