#29 Supposed fix for 3595560, VST-effect-GUI not shown

closed-fixed
None
5
2013-01-13
2013-01-08
Mike Choi
No

Supposed fix for 3595560, see also
http://sourceforge.net/apps/phpbb/lmms/viewtopic.php?f=7&t=778
http://sourceforge.net/tracker/?func=detail&aid=3595560&group_id=105168&atid=640434

Patch is against stable branch and should apply both on Win & Linux builds:
VST effects pluginWidget should not be deleted, when we close General Settings of this track / instrument,
where are directly attached VST effects, but only when we remove this VST effect itself.

Discussion

  • Mike Choi

    Mike Choi - 2013-01-08
    • assigned_to: nobody --> tobydox
     
  • Mike Choi

    Mike Choi - 2013-01-08

    There are still few different problems with VST effects attached directly to instruments, will try to address those later.

    For example, when we open instruments general settings (GS), VST plugin window is automatically opened too, when we close GS VST effect control window is closed as well and there are missing controls & buttons on this effect control window on Windows build.

     
  • Mike Choi

    Mike Choi - 2013-01-08
    • summary: upposed fix problem (3595560) VST-effect-GUI not shown --> Supposed fix problem (3595560) VST-effect-GUI not shown
     
  • Mike Choi

    Mike Choi - 2013-01-08
    • summary: Supposed fix problem (3595560) VST-effect-GUI not shown --> Supposed fix for problem 3595560, VST-effect-GUI not shown
     
  • Mike Choi

    Mike Choi - 2013-01-08
    • summary: Supposed fix for problem 3595560, VST-effect-GUI not shown --> Supposed fix for 3595560, VST-effect-GUI not shown
     
  • Mike Choi

    Mike Choi - 2013-01-12
    • summary: Supposed fix for 3595560, VST-effect-GUI not shown --> Fix for 3595560, VST-effect-GUI not shown
     
  • Mike Choi

    Mike Choi - 2013-01-12
    • summary: Fix for 3595560, VST-effect-GUI not shown --> Supposed fix for 3595560, VST-effect-GUI not shown
     
  • Mike Choi

    Mike Choi - 2013-01-12

    New patch version added, this one suppose to fix previous one, when you remove sample track with VST effects attached.

     
  • Tobias Junghans

    Tobias Junghans - 2013-01-13

    Thanks a lot for this patch! I applied and pushed it.

     
  • Tobias Junghans

    Tobias Junghans - 2013-01-13
    • status: open --> closed-fixed
     

Log in to post a comment.