From: Nikos C. <re...@ar...> - 2009-10-05 10:29:43
|
There seems to be a problem with the L key; it should play C#, but it doesn't. On a similar note, would it be too much work to extend the upper keyboard mapping to include: TAB - B [ - F = - F# ] - G BACKSPACE - G# \ - A That would be an *immense* help for people who need to use the keyboard, or to *also* use the keyboard in addition to a MIDI keyboard :) |
From: Andy K. <sup...@gm...> - 2009-10-05 10:47:32
|
That is quite possibly my fault - I bound 'L' to "change global playback mode." I didn't know we even supported using the keyboard as a midi input. The solution of course is a button toggling keyboard as a midi controller on or off. Make sure this gets reported as a bug and I will fix it eventually. On Mon, Oct 5, 2009 at 3:25 AM, Nikos Chantziaras <re...@ar...> wrote: > There seems to be a problem with the L key; it should play C#, but it > doesn't. > > On a similar note, would it be too much work to extend the upper > keyboard mapping to include: > > TAB - B > [ - F > = - F# > ] - G > BACKSPACE - G# > \ - A > > That would be an *immense* help for people who need to use the keyboard, > or to *also* use the keyboard in addition to a MIDI keyboard :) > > > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > LMMS-devel mailing list > LMM...@li... > https://lists.sourceforge.net/lists/listinfo/lmms-devel > -- Andy Kelley Nuclear Development http://nucleardev.com/ |
From: Nikos C. <re...@ar...> - 2009-10-05 11:32:21
Attachments:
extend_keyboard_midi_keys.patch
|
(Andy, sorry if this reaches you twice, the list bounced my previous attempt since I was posting through GMane before and forgot to subscribe to also subscribe to the list normally.) I will file a bug report about it. I also noticed that TAB (keycode 23 on Linux) also can't be used. I'm attaching a patch that adds: ` = A# TAB = B (but doesn't work, probably same reason L doesn't) [ = f' = = f'# ] = g' BACKSPACE = g'# \ = a'' If the patch is OK, it would be great if someone would push it. The patch is for Linux only; I don't know the scancodes of Windows and OS X :P On 10/05/2009 01:47 PM, Andy Kelley wrote: > That is quite possibly my fault - I bound 'L' to "change global playback > mode." > > I didn't know we even supported using the keyboard as a midi input. The > solution of course is a button toggling keyboard as a midi controller on > or off. > > Make sure this gets reported as a bug and I will fix it eventually. > > On Mon, Oct 5, 2009 at 3:25 AM, Nikos Chantziaras <re...@ar... > <mailto:re...@ar...>> wrote: > > There seems to be a problem with the L key; it should play C#, but it > doesn't. > > On a similar note, would it be too much work to extend the upper > keyboard mapping to include: > > TAB - B > [ - F > = - F# > ] - G > BACKSPACE - G# > \ - A > > That would be an *immense* help for people who need to use the keyboard, > or to *also* use the keyboard in addition to a MIDI keyboard :) |
From: Nikos C. <re...@ar...> - 2009-10-05 13:09:27
|
On 10/05/2009 02:32 PM, Nikos Chantziaras wrote: > I will file a bug report about it. I also noticed that TAB (keycode 23 > on Linux) also can't be used. I filed the bug report. Also, I made TAB work by overriding QWidget::event(). However, can someone help me a bit with a GCC error I get? This: bool PianoView::event( QEvent * event ) { if (event->type() == QEvent::KeyPress) { QKeyEvent *ke = static_cast<QKeyEvent *>(event); if (ke->key() == Qt::Key_Tab) { keyPressEvent(ke); return true; } } return QWidget::event(event); } Results in GCC barking: error: expected unqualified-id before numeric constant If I replace: if (event->type() == QEvent::KeyPress) { with: if (event->type() == 6) { (QEvent::KeyPress's value is 6) then it compiles and works as intended. But of course using 6 isn't nice. |
From: Nikos C. <re...@ar...> - 2009-10-05 16:33:36
Attachments:
extend_keyboard_midi_keys.patch
|
I wrapped up my patch that enables additional keyboard keys to be used for playing notes. Please consider it for inclusion in LMMS. |
From: Nikos C. <re...@ar...> - 2011-09-12 16:45:12
Attachments:
extend_keyboard_midi_keys.patch
|
On 10/05/2009 07:33 PM, Nikos Chantziaras wrote: > I wrapped up my patch that enables additional keyboard keys to be used > for playing notes. Please consider it for inclusion in LMMS. Yes, I'm still using that patch 2 years later. If anyone else does, I rebased it so it applies against current Git (stable-0.4 branch). I'm attaching it to this post. (What this patch does is fit more notes on your PC keyboard.) |
From: Paul G. <dr...@gm...> - 2009-10-05 18:57:16
|
Personally, I'd prefer the . / ; ' [ ] - = \ ` and 1 keys be reserved for context-aware shortcuts in the future On Mon, Oct 5, 2009 at 12:33 PM, Nikos Chantziaras <re...@ar...> wrote: > I wrapped up my patch that enables additional keyboard keys to be used for > playing notes. Please consider it for inclusion in LMMS. > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > LMMS-devel mailing list > LMM...@li... > https://lists.sourceforge.net/lists/listinfo/lmms-devel > > |
From: Nikos C. <re...@ar...> - 2009-10-05 19:17:54
|
Since this is local to PianoView, the keys shouldn't interfere with shortcuts, unless it has keyboard focus. Anyway, I guess instead of "uber-awesome configurable shortcuts", the most straight-forward way to get rid of all PianoView keys is to make PianoView itself a toggle (a small on/off switch inside widgets that embed a PianoView). If the PianoView is disabled, none of the keys have any special meaning anymore. So with such a toggle, one could quicky and easily bring a PianoView on screen when needed and then disable it again. On 10/05/2009 09:57 PM, Paul Giblock wrote: > Personally, I'd prefer the . / ; ' [ ] - = \ ` and 1 keys be reserved > for context-aware shortcuts in the future > > On Mon, Oct 5, 2009 at 12:33 PM, Nikos Chantziaras<re...@ar...> wrote: >> I wrapped up my patch that enables additional keyboard keys to be used for >> playing notes. Please consider it for inclusion in LMMS. -- |
From: Jonathan A. <eag...@gm...> - 2009-10-05 12:02:29
|
would this be easier to change for instance to bind the keys of a keyboard a b c d and so on to the same keys on the keyboard and then use the plus or minus to make it into a sharp or a flat? On Mon, Oct 5, 2009 at 1:32 PM, Nikos Chantziaras <re...@ar...> wrote: > (Andy, sorry if this reaches you twice, the list bounced my previous > attempt since I was posting through GMane before and forgot to subscribe to > also subscribe to the list normally.) > > I will file a bug report about it. I also noticed that TAB (keycode 23 on > Linux) also can't be used. > > I'm attaching a patch that adds: > > ` = A# > TAB = B (but doesn't work, probably same reason L doesn't) > [ = f' > = = f'# > ] = g' > BACKSPACE = g'# > \ = a'' > > If the patch is OK, it would be great if someone would push it. The patch > is for Linux only; I don't know the scancodes of Windows and OS X :P > > > On 10/05/2009 01:47 PM, Andy Kelley wrote: > >> That is quite possibly my fault - I bound 'L' to "change global playback >> mode." >> >> I didn't know we even supported using the keyboard as a midi input. The >> solution of course is a button toggling keyboard as a midi controller on >> or off. >> >> Make sure this gets reported as a bug and I will fix it eventually. >> >> On Mon, Oct 5, 2009 at 3:25 AM, Nikos Chantziaras <re...@ar... >> <mailto:re...@ar...>> wrote: >> >> There seems to be a problem with the L key; it should play C#, but it >> doesn't. >> >> On a similar note, would it be too much work to extend the upper >> keyboard mapping to include: >> >> TAB - B >> [ - F >> = - F# >> ] - G >> BACKSPACE - G# >> \ - A >> >> That would be an *immense* help for people who need to use the >> keyboard, >> or to *also* use the keyboard in addition to a MIDI keyboard :) >> > > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > LMMS-devel mailing list > LMM...@li... > https://lists.sourceforge.net/lists/listinfo/lmms-devel > > -- Jonathan Aquilina |
From: Nikos C. <re...@ar...> - 2009-10-05 12:47:58
|
That wouldn't work. If you try to play something and need to switch to flats in the midst of it... Just awkward :P On 10/05/2009 03:01 PM, Jonathan Aquilina wrote: > would this be easier to change for instance to bind the keys of a > keyboard a b c d and so on to the same keys on the keyboard and then use > the plus or minus to make it into a sharp or a flat? > > On Mon, Oct 5, 2009 at 1:32 PM, Nikos Chantziaras <re...@ar... > <mailto:re...@ar...>> wrote: > > (Andy, sorry if this reaches you twice, the list bounced my previous > attempt since I was posting through GMane before and forgot to > subscribe to also subscribe to the list normally.) > > I will file a bug report about it. I also noticed that TAB (keycode > 23 on Linux) also can't be used. > > I'm attaching a patch that adds: > > ` = A# > TAB = B (but doesn't work, probably same reason L doesn't) > [ = f' > = = f'# > ] = g' > BACKSPACE = g'# > \ = a'' > > If the patch is OK, it would be great if someone would push it. The > patch is for Linux only; I don't know the scancodes of Windows and > OS X :P > > > > On 10/05/2009 01:47 PM, Andy Kelley wrote: > > That is quite possibly my fault - I bound 'L' to "change global > playback > mode." > > I didn't know we even supported using the keyboard as a midi > input. The > solution of course is a button toggling keyboard as a midi > controller on > or off. > > Make sure this gets reported as a bug and I will fix it eventually. > > On Mon, Oct 5, 2009 at 3:25 AM, Nikos Chantziaras > <re...@ar... <mailto:re...@ar...> > <mailto:re...@ar... <mailto:re...@ar...>>> wrote: > > There seems to be a problem with the L key; it should play > C#, but it > doesn't. > > On a similar note, would it be too much work to extend the upper > keyboard mapping to include: > > TAB - B > [ - F > = - F# > ] - G > BACKSPACE - G# > \ - A > > That would be an *immense* help for people who need to use > the keyboard, > or to *also* use the keyboard in addition to a MIDI keyboard :) |
From: Jonathan A. <eag...@gm...> - 2009-10-05 12:29:58
|
what about in that case if you press the corresponding multiple times it changes to sharps and or flats with each press as need be ex press f repeatedly goes to sharp flat natural no sign double sharp or flat On Mon, Oct 5, 2009 at 2:15 PM, Nikos Chantziaras <re...@ar...> wrote: > That wouldn't work. If you try to play something and need to switch to > flats in the midst of it... Just awkward :P > > On 10/05/2009 03:01 PM, Jonathan Aquilina wrote: > >> would this be easier to change for instance to bind the keys of a >> keyboard a b c d and so on to the same keys on the keyboard and then use >> the plus or minus to make it into a sharp or a flat? >> >> On Mon, Oct 5, 2009 at 1:32 PM, Nikos Chantziaras <re...@ar... >> <mailto:re...@ar...>> wrote: >> >> (Andy, sorry if this reaches you twice, the list bounced my previous >> attempt since I was posting through GMane before and forgot to >> subscribe to also subscribe to the list normally.) >> >> I will file a bug report about it. I also noticed that TAB (keycode >> 23 on Linux) also can't be used. >> >> I'm attaching a patch that adds: >> >> ` = A# >> TAB = B (but doesn't work, probably same reason L doesn't) >> [ = f' >> = = f'# >> ] = g' >> BACKSPACE = g'# >> \ = a'' >> >> If the patch is OK, it would be great if someone would push it. The >> patch is for Linux only; I don't know the scancodes of Windows and >> OS X :P >> >> >> >> On 10/05/2009 01:47 PM, Andy Kelley wrote: >> >> That is quite possibly my fault - I bound 'L' to "change global >> playback >> mode." >> >> I didn't know we even supported using the keyboard as a midi >> input. The >> solution of course is a button toggling keyboard as a midi >> controller on >> or off. >> >> Make sure this gets reported as a bug and I will fix it eventually. >> >> On Mon, Oct 5, 2009 at 3:25 AM, Nikos Chantziaras >> <re...@ar... <mailto:re...@ar...> >> <mailto:re...@ar... <mailto:re...@ar...>>> wrote: >> >> There seems to be a problem with the L key; it should play >> C#, but it >> doesn't. >> >> On a similar note, would it be too much work to extend the >> upper >> keyboard mapping to include: >> >> TAB - B >> [ - F >> = - F# >> ] - G >> BACKSPACE - G# >> \ - A >> >> That would be an *immense* help for people who need to use >> the keyboard, >> or to *also* use the keyboard in addition to a MIDI keyboard :) >> > -- Jonathan Aquilina |
From: Nikos C. <re...@ar...> - 2009-10-05 13:02:08
|
That doesn't make sense to me. Try playing a melody that way, it just won't work. Imagine removing all the black keys from your MIDI keyboard and having to press a white one repeatedly to switch to flats. Now try playing something on such a keyboard :P On 10/05/2009 03:22 PM, Jonathan Aquilina wrote: > what about in that case if you press the corresponding multiple times it > changes to sharps and or flats with each press as need be > > ex > > press f repeatedly goes to sharp flat natural no sign double sharp or flat > > On Mon, Oct 5, 2009 at 2:15 PM, Nikos Chantziaras <re...@ar... > <mailto:re...@ar...>> wrote: > > That wouldn't work. If you try to play something and need to switch > to flats in the midst of it... Just awkward :P > > > On 10/05/2009 03:01 PM, Jonathan Aquilina wrote: > > would this be easier to change for instance to bind the keys of a > keyboard a b c d and so on to the same keys on the keyboard and > then use > the plus or minus to make it into a sharp or a flat? > > On Mon, Oct 5, 2009 at 1:32 PM, Nikos Chantziaras > <re...@ar... <mailto:re...@ar...> > <mailto:re...@ar... <mailto:re...@ar...>>> wrote: > > (Andy, sorry if this reaches you twice, the list bounced my > previous > attempt since I was posting through GMane before and forgot to > subscribe to also subscribe to the list normally.) > > I will file a bug report about it. I also noticed that TAB > (keycode > 23 on Linux) also can't be used. > > I'm attaching a patch that adds: > > ` = A# > TAB = B (but doesn't work, probably same reason L doesn't) > [ = f' > = = f'# > ] = g' > BACKSPACE = g'# > \ = a'' > > If the patch is OK, it would be great if someone would push > it. The > patch is for Linux only; I don't know the scancodes of > Windows and > OS X :P > > > > On 10/05/2009 01:47 PM, Andy Kelley wrote: > > That is quite possibly my fault - I bound 'L' to "change > global > playback > mode." > > I didn't know we even supported using the keyboard as a midi > input. The > solution of course is a button toggling keyboard as a midi > controller on > or off. > > Make sure this gets reported as a bug and I will fix it > eventually. > > On Mon, Oct 5, 2009 at 3:25 AM, Nikos Chantziaras > <re...@ar... <mailto:re...@ar...> > <mailto:re...@ar... <mailto:re...@ar...>> > <mailto:re...@ar... <mailto:re...@ar...> > <mailto:re...@ar... <mailto:re...@ar...>>>> wrote: > > There seems to be a problem with the L key; it > should play > C#, but it > doesn't. > > On a similar note, would it be too much work to > extend the upper > keyboard mapping to include: > > TAB - B > [ - F > = - F# > ] - G > BACKSPACE - G# > \ - A > > That would be an *immense* help for people who need > to use > the keyboard, > or to *also* use the keyboard in addition to a MIDI > keyboard :) |
From: <ap...@dk...> - 2009-10-05 13:43:39
|
Hi all. Well actually I can't recommend such an implementation and I second Nikos' reasons here. The problem with LMMS' keyboard in general is, dependent on on the current codec in use (at least, this is my assumption - I got a qwertz layout) not all available keys are used. ZynAddSubfx on the other hand does handle this in a much better way making it possible to play a bit higher melodies. In the end, there is no way a pc keyboard would replace a real one like you all do know. E.g. the completely random (at least it seems so) limit of simultaneous key presses of 5 different keys depending on the location is making the pc keyboard hardly useful. Best regards apriori > That doesn't make sense to me. Try playing a melody that way, it just > won't work. Imagine removing all the black keys from your MIDI keyboard > and having to press a white one repeatedly to switch to flats. Now try > playing something on such a keyboard :P > > On 10/05/2009 03:22 PM, Jonathan Aquilina wrote: > > what about in that case if you press the corresponding multiple times it > > changes to sharps and or flats with each press as need be > > > > ex > > > > press f repeatedly goes to sharp flat natural no sign double sharp or > > flat > > > > On Mon, Oct 5, 2009 at 2:15 PM, Nikos Chantziaras <re...@ar... > > <mailto:re...@ar...>> wrote: > > > > That wouldn't work. If you try to play something and need to switch > > to flats in the midst of it... Just awkward :P > > > > > > On 10/05/2009 03:01 PM, Jonathan Aquilina wrote: > > > > would this be easier to change for instance to bind the keys of a > > keyboard a b c d and so on to the same keys on the keyboard and > > then use > > the plus or minus to make it into a sharp or a flat? > > > > On Mon, Oct 5, 2009 at 1:32 PM, Nikos Chantziaras > > <re...@ar... <mailto:re...@ar...> > > <mailto:re...@ar... <mailto:re...@ar...>>> wrote: > > > > (Andy, sorry if this reaches you twice, the list bounced my > > previous > > attempt since I was posting through GMane before and forgot > > to subscribe to also subscribe to the list normally.) > > > > I will file a bug report about it. I also noticed that TAB > > (keycode > > 23 on Linux) also can't be used. > > > > I'm attaching a patch that adds: > > > > ` = A# > > TAB = B (but doesn't work, probably same reason L doesn't) > > [ = f' > > = = f'# > > ] = g' > > BACKSPACE = g'# > > \ = a'' > > > > If the patch is OK, it would be great if someone would push > > it. The > > patch is for Linux only; I don't know the scancodes of > > Windows and > > OS X :P > > > > > > > > On 10/05/2009 01:47 PM, Andy Kelley wrote: > > > > That is quite possibly my fault - I bound 'L' to "change > > global > > playback > > mode." > > > > I didn't know we even supported using the keyboard as a > > midi input. The > > solution of course is a button toggling keyboard as a > > midi controller on > > or off. > > > > Make sure this gets reported as a bug and I will fix it > > eventually. > > > > On Mon, Oct 5, 2009 at 3:25 AM, Nikos Chantziaras > > <re...@ar... <mailto:re...@ar...> > > <mailto:re...@ar... <mailto:re...@ar...>> > > <mailto:re...@ar... <mailto:re...@ar...> > > <mailto:re...@ar... <mailto:re...@ar...>>>> wrote: > > > > There seems to be a problem with the L key; it > > should play > > C#, but it > > doesn't. > > > > On a similar note, would it be too much work to > > extend the upper > > keyboard mapping to include: > > > > TAB - B > > [ - F > > = - F# > > ] - G > > BACKSPACE - G# > > \ - A > > > > That would be an *immense* help for people who need > > to use > > the keyboard, > > or to *also* use the keyboard in addition to a MIDI > > keyboard :) > > --------------------------------------------------------------------------- > --- Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register > now! http://p.sf.net/sfu/devconf > _______________________________________________ > LMMS-devel mailing list > LMM...@li... > https://lists.sourceforge.net/lists/listinfo/lmms-devel > |
From: Nikos C. <re...@ar...> - 2009-10-05 16:43:59
|
On 10/05/2009 04:19 PM, ap...@dk... wrote: > Hi all. > > Well actually I can't recommend such an implementation and I second Nikos' > reasons here. The problem with LMMS' keyboard in general is, dependent on on > the current codec in use (at least, this is my assumption - I got a qwertz > layout) not all available keys are used. LMMS uses the key's scancode as reported by the hardware (at least on Linux), so keyboard layout shouldn't actually matter. Even on QWERTZ, "Z" should play the same note as "Y" on QWERTY keyboards. I think :P |
From: Paul G. <dr...@gm...> - 2009-10-05 18:59:46
|
Please read my previous post. I agree 'L' needs to be given back to the C#. However, please do not extend the range to the - = \ ` [ ] ; '. / keys. At leat - not right now, maybe once we start using QAction consistently and support uber-awesome configurable keyboard shortcuts. -Paul On Mon, Oct 5, 2009 at 12:43 PM, Nikos Chantziaras <re...@ar...> wrote: > On 10/05/2009 04:19 PM, ap...@dk... wrote: >> Hi all. >> >> Well actually I can't recommend such an implementation and I second Nikos' >> reasons here. The problem with LMMS' keyboard in general is, dependent on on >> the current codec in use (at least, this is my assumption - I got a qwertz >> layout) not all available keys are used. > > LMMS uses the key's scancode as reported by the hardware (at least on > Linux), so keyboard layout shouldn't actually matter. Even on QWERTZ, > "Z" should play the same note as "Y" on QWERTY keyboards. I think :P > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > LMMS-devel mailing list > LMM...@li... > https://lists.sourceforge.net/lists/listinfo/lmms-devel > |