#21 0.9.1a: lircd segfaults when connect option is used in configuration files

[Evilandi666]

In 0.9.1a, lircd crashes with a segmentation fault if it is started with a filled connect field in the configuration file lirc_options.conf.

For Example start lircd with the following lirc_options.conf:

[lircd]
nodaemon        = False
permission      = 666
driver          = default
device          = /dev/lirc0
lircdfile       = /var/run/lirc/lircd
pidfile         = /var/run/lirc/lircd.pid
plugindir       = /usr/lib/lirc/plugins
allow-simulate  = No
repeat-max      = 600
#listen         = [address:]port
connect        = SomeHost
#debug          = 5
#uinput         = ...
#release        = ...
#logfile        = ...

[lircmd]
uinput          = False
nodeamon        = False

Lircd segfaults immediately after start. connect is commented out in standard config, so this bug is only visible if you using the connect option in lirc_options.conf.

The segfault is happening because there is 'optargs' instead of 'opt' passed to add_peer_connection() in lircd.c at line 2314 (version 0.9.1a). See attached patch.

[Alec Leamas]

Thanks for reporting + patch! Fixed in [02252a] in release_0.9.1b branch and [b66f5d] in master

EDIT: Updating links

[Alec Leamas]

Time to close.