From: Mario L. <mar...@gm...> - 2007-12-30 08:14:06
Attachments:
signature.asc
27_multiple_include.dpatch
|
Hi everyone, I'm attaching a patch that I created to improve lircd.conf reading. It adds support for the "include" directive within lircd.conf. This lets you customize your configuration without having to hand append each remote. Using this patch, in Ubuntu we are able to do things like this for our lircd.conf: #This configuration has been automatically generated via #the Ubuntu LIRC package maintainer scripts. # #It includes the remote and/or transmitter that you have #selected during package installation. # #Feel free to add any custom remotes to the configuration #via additional include directives or below the existing #Ubuntu include directives from your selected remote and/or #transmitter. #Ubuntu configuration, setup to include specific remote: include /usr/share/lirc/remotes/streamzap/lircd.conf.streamzap Note, the patch is listed as a dpatch, but applies cleanly using a simple patch command (it is just like using a unified diff). -- Mario Limonciello mar...@gm... |
From: Paul B. <peb...@sa...> - 2007-12-30 16:02:51
|
Mario Limonciello wrote: > Hi everyone, > > I'm attaching a patch that I created to improve lircd.conf reading. > It adds support for the "include" directive within lircd.conf. > > This lets you customize your configuration without having to hand append each > remote. Thank you! I had been contemplating creating an LIRC patch to do the same thing for use in MiniMyth. This will be quite useful to me. |
From: Paul B. <peb...@sa...> - 2007-12-30 23:36:41
|
Paul Bender wrote: > Mario Limonciello wrote: >> Hi everyone, >> >> I'm attaching a patch that I created to improve lircd.conf reading. >> It adds support for the "include" directive within lircd.conf. >> >> This lets you customize your configuration without having to hand append each >> remote. > > Thank you! > > I had been contemplating creating an LIRC patch to do the same thing for > use in MiniMyth. This will be quite useful to me. I added the patch to MiniMyth. It works well. Again, thank you. |
From: Mario L. <mar...@gm...> - 2007-12-31 07:46:39
Attachments:
signature.asc
|
Paul Bender wrote: > Paul Bender wrote: >> Mario Limonciello wrote: >>> Hi everyone, >>> >>> I'm attaching a patch that I created to improve lircd.conf reading. >>> It adds support for the "include" directive within lircd.conf. >>> >>> This lets you customize your configuration without having to hand app= end each >>> remote. >> Thank you! >> >> I had been contemplating creating an LIRC patch to do the same thing f= or=20 >> use in MiniMyth. This will be quite useful to me. >=20 > I added the patch to MiniMyth. It works well. Again, thank you. >=20 > -----------------------------------------------------------------------= -- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2005. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ Great! Hope to see Christoph commit this to cvs then too :) --=20 Mario Limonciello mar...@gm... |
From: <li...@ba...> - 2007-12-31 15:09:49
|
Hi! Mario Limonciello "mar...@gm..." wrote: > I'm attaching a patch that I created to improve lircd.conf reading. > It adds support for the "include" directive within lircd.conf. [...] I like the idea. I don't like the implementation because: - it depends on absolute filenames - it will not work with filenames that contain whitespace Please take a look at the implementation of the include directive inside lirc_client.c for reference. Christoph |
From: Bastien N. <ha...@ha...> - 2008-04-16 10:50:07
|
Christoph Bartelmus <lirc@...> writes: Heya > Mario Limonciello "mario.mailing@..." wrote: > > I'm attaching a patch that I created to improve lircd.conf reading. > > It adds support for the "include" directive within lircd.conf. > [...] > > I like the idea. I don't like the implementation because: > - it depends on absolute filenames > - it will not work with filenames that contain whitespace Patch coming to implement something similar to the code in lirc_client.c I don't see how this fixes the absolute filenames problems though. We'd need to have another directive containing a searchpath to avoid using absolute filenames, or did you just want to have names relative to the current config file location working? Cheers |
From: Bastien N. <ha...@ha...> - 2008-04-16 10:51:29
Attachments:
lirc-include.patch
|
On Wed, 2008-04-16 at 10:48 +0000, Bastien Nocera wrote: > Christoph Bartelmus <lirc@...> writes: > > Heya > > > Mario Limonciello "mario.mailing@..." wrote: > > > I'm attaching a patch that I created to improve lircd.conf reading. > > > It adds support for the "include" directive within lircd.conf. > > [...] > > > > I like the idea. I don't like the implementation because: > > - it depends on absolute filenames > > - it will not work with filenames that contain whitespace > > Patch coming to implement something similar to the code in lirc_client.c > > I don't see how this fixes the absolute filenames problems though. We'd need to > have another directive containing a searchpath to avoid using absolute > filenames, or did you just want to have names relative to the current config > file location working? Patch attached. Cheers |
From: <li...@ba...> - 2008-04-19 14:13:52
|
Hi! Bastien Nocera "ha...@ha..." wrote: [...] >>> I'm attaching a patch that I created to improve lircd.conf reading. >>> It adds support for the "include" directive within lircd.conf. [...] >> I like the idea. I don't like the implementation because: >> - it depends on absolute filenames >> - it will not work with filenames that contain whitespace > Patch coming to implement something similar to the code in lirc_client.c > > I don't see how this fixes the absolute filenames problems though. We'd need > to have another directive containing a searchpath to avoid using absolute > filenames, or did you just want to have names relative to the current config > file location working? Yes, support for names relative to the current config file location would be great. Christoph |
From: Bastien N. <ha...@ha...> - 2008-04-21 10:46:40
Attachments:
lirc-include-2.patch
|
On Sat, 2008-04-19 at 16:13 +0200, Christoph Bartelmus wrote: > Hi! > > Bastien Nocera "ha...@ha..." wrote: > [...] > >>> I'm attaching a patch that I created to improve lircd.conf reading. > >>> It adds support for the "include" directive within lircd.conf. > [...] > >> I like the idea. I don't like the implementation because: > >> - it depends on absolute filenames > >> - it will not work with filenames that contain whitespace > > > Patch coming to implement something similar to the code in lirc_client.c > > > > I don't see how this fixes the absolute filenames problems though. We'd need > > to have another directive containing a searchpath to avoid using absolute > > filenames, or did you just want to have names relative to the current config > > file location working? > > Yes, support for names relative to the current config file location would > be great. Here goes. It's a very naive implementation, but should work fine on any Unix systems. Cheers |
From: <li...@ba...> - 2008-05-09 18:46:53
|
Hi! Bastien Nocera "ha...@ha..." wrote: [...] > Here goes. It's a very naive implementation, but should work fine on any > Unix systems. I have included this patch in CVS after making some substantial modifications. Please test if it still works like expected. Christoph |
From: Bastien N. <ha...@ha...> - 2008-05-11 11:55:45
|
On Fri, 2008-05-09 at 20:46 +0200, Christoph Bartelmus wrote: > Hi! > > Bastien Nocera "ha...@ha..." wrote: > [...] > > Here goes. It's a very naive implementation, but should work fine on any > > Unix systems. > > I have included this patch in CVS after making some substantial > modifications. Please test if it still works like expected. Seems to work just fine. Thanks |