From: Bengt M. <bu...@be...> - 2017-08-31 07:31:24
|
Good morning. This is so weird that I ask before starting to debug... Since recently, make is broken in the sense that it keeps rebuilding what is already built and up to date. To be more explicit ./autogen.sh ./configure make # Builds ok make # Builds everything again! Current master from Sourceforge git, Fedora 26. |
From: Alec L. <lea...@gm...> - 2017-08-31 07:34:36
|
On 31/08/17 09:31, Bengt Martensson wrote: > Good morning. > > This is so weird that I ask before starting to debug... > > Since recently, make is broken in the sense that it keeps rebuilding > what is already built and up to date. To be more explicit > > ./autogen.sh > ./configure > make # Builds ok > make # Builds everything again! > Yup, I've noted the same... --alec |
From: Alec L. <lea...@gm...> - 2017-08-31 10:34:30
|
On 31/08/17 09:34, Alec Leamas wrote: > > > On 31/08/17 09:31, Bengt Martensson wrote: >> >> Since recently, make is broken in the sense that it keeps rebuilding >> what is already built and up to date. To be more explicit >> > Yup, I've noted the same... > It's probably about this piece in lib/Makefile.am input_map.lo: lirc/input_map.inc input_map.inc: lirc/input_map.inc lirc/input_map.inc: lirc i. e., input_map.inc depends on the complete lirc directory which is a symlink lirc -> . and as such always changed. Will look into it later. --alec |
From: Bengt M. <bu...@be...> - 2017-08-31 11:12:54
|
On 08/31/17 12:34, Alec Leamas wrote: > > > On 31/08/17 09:34, Alec Leamas wrote: >> >> >> On 31/08/17 09:31, Bengt Martensson wrote: >>> >>> Since recently, make is broken in the sense that it keeps rebuilding >>> what is already built and up to date. To be more explicit >>> >> Yup, I've noted the same... >> > > It's probably about this piece in lib/Makefile.am > > input_map.lo: lirc/input_map.inc > > input_map.inc: lirc/input_map.inc > > lirc/input_map.inc: lirc > > i. e., input_map.inc depends on the complete lirc directory which is a > symlink lirc -> . and as such always changed. Will look into it later. Thanx. Then here is a fix (3 characters added...: diff --git a/lib/Makefile.am b/lib/Makefile.am index 065b0c9c..e513c537 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -128,7 +128,7 @@ lirc: .phony config.h: ../config.h -cp $? $@ -lirc/config.h: ../config.h lirc +lirc/config.h: ../config.h | lirc -cp ../config.h $@ ../paths.h: .phony @@ -137,14 +137,14 @@ lirc/config.h: ../config.h lirc paths.h: ../paths.h -cp $? $@ -lirc/paths.h: ../paths.h lirc +lirc/paths.h: ../paths.h | lirc -cp ../paths.h $@ input_map.lo: lirc/input_map.inc input_map.inc: lirc/input_map.inc -lirc/input_map.inc: lirc +lirc/input_map.inc: | lirc PYTHON=$(PYTHON) $(top_srcdir)/tools/lirc-make-devinput \ -i $(DEVINPUT_HEADER) > input_map.inc PYTHON=$(PYTHON) $(top_srcdir)/tools/lirc-make-devinput \ |
From: Alec L. <lea...@gm...> - 2017-08-31 17:47:59
|
On 31/08/17 09:31, Bengt Martensson wrote: [ nice patch ] Thanks, committed on top of master and release-0.10 I forgot to attribute the patch to you. I apologize. --alec |