On 07/31/14 22:52, Alec Leamas wrote:
> I have just pushed new commits which enables dynamic loading of drivers.
> The basic idea is to make it easier to build, install and enhance lirc.
> Instead of the complicated code for building the right driver for
> different scenarios we just build all drivers, and loads the one(s) used.
>
> This also open up for building drivers out-of-tree which should make it
> easier to create user-space drivers.
Kewl. There is a number of use cases that comes to mind.
> The bad news is that the master branch probably is destabilized by these
> by these somewhat large changes.
Don't worry. LIRC has never been a "start by getting the sources from
git/svn"-project anyhow. Important thing is to declare the branch as not
stable.
Here are some minor glitches and suggestions. This time rather
superficial, but as a start.
* For development, I like to configure with --prefix=/my/own/root and
have everything (but the /dev directory) being installed/generated
therein. In particular, I do not want make install to fiddle with /etc
or /var, or /usr. There are pretty many things that breaks here, I will
send you a list of my fixes privately.
* lirc.pc and lirc-driver.pc are missing.
* $devdir_default broken on non-darwin
* $localstatedir/log not created if not existing (related to the first
point)
* Suggestion: configure shold write a summary at end which drivers will
be built and which not.
* Suggestion: dynamic driver should be possible to pass arguments (like
gcc can pass arguments to the linker). Like:
lircd -H globalcache --driverparam ip=192.168.1.70
* $devdir_default broken on non-darwin, leading to silly DEVDIR in config.h
* Suggestion: rename lircd.conf.$REMOTE to $REMOTE.lirc
* Suggestion: rename iguanaIR to iguanair.
* Logfile handling is sub-optimal. Logfile is opened before evaluating
arguments like --help; this is unclean, because a --help should not
create a log file. Also, it is opened *before* the --logfile argument
is evaluated.
I will send you some fixes privately.
Greets,
Bengt
|
