Git Merge Request #2: Support for sony IR receiver. (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Eric Anderson wants to merge 1 commit from /u/rico9999/lirc/ to master, 2014-08-20

Support for PCVA-IR5U (USB IR receiver).

Commit Date  
[f7c283] by Eric Anderson Eric Anderson

Adding support for sony IR receiver. (PCVA-IR5U)
A few changes to make compilation more straightforward under macosx:
* In a couple of scripts, 'sed' needs to be changed to 'gsed'.
* Add defines for __u64, etc. in two files.
* Change 'expr length $NAME' to '${#NAME}'.
Some changes to configure.ac for autoconf, automake.

2013-10-16 05:46:51 Tree

Discussion

  • Alec Leamas

    Alec Leamas - 2013-11-09

    Hm... This is a huge commit. IMHO, this would be easier to review if split into some smaller. I can see at least general autotools updates (partly the same as my), Darwin-specific but otherwise generic buildsys updates, new remote definitions and the "real" changes - the latter could perhaps be split as well.

    That said, I'm not upstream, it's just my 5 öre.

     
  • Alec Leamas

    Alec Leamas - 2014-04-04

    Hi!

    OK, I have splitted this commit and merged into my tree (which hopefully will be merged upstream at some point).

    You can find the actual state at https://github.com/leamas/yab/, in the devel branch.

    The Darwin build fixes have been merged verbatim in a commit [1] labeled "scripts, lircmd.c, ir_remote_types.h: Darwin build fixes"

    The hw_hiddev patch is also more or less verbatim in a commit[2] labeled "plugins: hw_hiddev.c: Add sonyir support". However, the context here is different since drivers are built separately and loaded dynamically. This also means that many other changes to e. g., setup.data and configure.ac just don't apply. Instead, the new driver is included in doc/hardware.yaml, the source for the driver table and the configuration support (lirc-setup).

    I have split the lircd.conf file into separate files for each remote. This makes maintenance a bit simpler. However, if it's a reasonable scenario to use several of these remotes at once we need to reconsider this.

    I'm very interested in feedback. The first would be if the commit labeled "contrib, doc: Add some irexec support" actually builds on Darwin. Of course, the same question is also highly relevant for the tip of this tree.

    Hope you still have some interest in this. I'm doing what I can to get it upstream. I cannot promise anything, but I have some kind of dialog with the upstream - not everything of this is visible, though.

    cheers!

    --alec

    [1] https://github.com/leamas/yab/commit/817815c2a81052778212d4fd1eb0c9a657d14738
    [2] https://github.com/leamas/yab/commit/4efebae0412fc9189baccc8e8c14b5d9a197ad3f

     
    Last edit: Alec Leamas 2014-04-04
  • Alec Leamas

    Alec Leamas - 2014-04-09

    The Darwin build fixes are now in the misc-fixes branch on sf.net (see mailing list) which hopefully will be merged "soon". Again: feedback welcome!

     
    Last edit: Alec Leamas 2014-04-09
  • Eric Anderson

    Eric Anderson - 2014-07-12

    Alec, thanks for picking up what you did! For what remains, I'll split this up into more manageable pieces and try again.

     
  • Alec Leamas

    Alec Leamas - 2014-07-13

    You're welcome, and thanks for your work! Note that the future lirc is in the ng branch.

    I'm on holiday, it will take some time before I look into lirc...

     
  • Alec Leamas

    Alec Leamas - 2014-08-19

    Most of this is actually merged, and if/when something more should be it's probably better to create a new request. many thanks for these patches!

     
  • Alec Leamas

    Alec Leamas - 2014-08-19
    • Status: open --> merged
     
  • Alec Leamas

    Alec Leamas - 2014-08-20

    Hm... Have you any chance to test what's in master as of now? You seem to have a remote to test with :)

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks