From: kaz K. <kk...@rr...> - 2003-06-12 08:26:42
|
Paul Mundt <le...@li...> wrote: >Ideally it would be nice if -m4-nofpu actually did the -U__sh3__ -D__SH4__ by >default, since obviously one would assume that -m4 indicates SH-4. Fixing >broken GCC behavior would seem to be a more useful practice then attempting to >hack around it in the kernel (we already do enough of that!). The problem is the meaning of the macro __sh3__ and __SH4__. If they simply means CPU, you are right. But if they means ABI, the current -m4-nofpu does the correct thing, because the purpose of -m4-nofpu is to make programs having SH-3 like ABI and working on SH-4 CPU. It would be better to separate these two meanings. >As a workaround for some of this stupidity, I went through and changed most of >the __sh3__ and __SH4__ checks to CONFIG_CPU_SH3 and CONFIG_CPU_SH4 -- since >obviously we can't rely on GCC to be correct. So, it might be not only a workaround but also the Right Thing. Regards, kaz |