[linuxsh-dev] Re: [linux-sh:02739] new board for 2.5.69

[Paul M. <le...@li...>]

On Fri, May 16, 2003 at 03:19:53PM +0900, ks...@in... wrote:
> We ported CVS HEAD to our mpc1211 hardware. Now it works very well
> with almost i/o the board has, including USB devices. Can we
> contribute it to LinuxSH, if it's ok?
> 
This looks good, though I have a few suggestions.

For starters, save_and_cli()/restore_flags() are deprecated, please
don't use them. I killed support for these in HEAD quite awhile ago, so
as-is, your code won't compile in current HEAD. (This is a trivial fix
though, as local_irq_save()/local_irq_restore() will do what you want).

Secondly, the old pcibios interface is also deprecated. We're using the
PCI auto interface now, though some of the boards are still pending
updating. See the Dreamcast code for an example of how to integrate your
changes with the new API. I suppose the hack to pcibios_align_resource()
will still be needed though, but to arch/sh/kernel/pci.c instead.

Another, mostly cosmetic issue, in arch/sh/Makefile, there's no need to
define incdir-y for your board. The only reason this exists is for
boards who have a different name in include/asm-sh then they do in
arch/sh/boards. ie, the SolutionEngine7751 code resides in
arch/sh/boards/se/7751 and has its headers under include/asm-sh/se7751.
This is needed to make the board symlink, so asm/mach will reference
whatever current board you have the kernel configured for.

The rest of it looks good, since the pci code is the only
save_and_cli()/restore_flags() user, I'll merge the rest of the patch
for the time being, and will merge the pci code once its been cleaned
up.