Re: [linux-sh:02725] Re: [linuxsh-dev] a 2.5.69 local patch

[Paul M. <le...@li...>]

On Wed, May 07, 2003 at 06:18:11PM +0900, SUGIOKA Toshinobu wrote:
> Thanks a lot. I tried this patch on my SH-7750R (which has 2-way cache) board.
> With a few changes, it worked very well.
> X window system with vnc-server runs on this kernel.
> 
Okay, overall this looks good, though I have a few suggestions. For one,
I just fixed up flush_icache_range() in HEAD to clear out the valid bit
per-way, which it wasn't doing before. Please try this first and see if
it works for you. If it turns out that flush_cache_all() is faster, then
obviously we can use that, but I'd like to avoid excessive flushing.

Secondly, there were a few fixups posted earlier for
__flush_dcache_all() and flush_cache_4096_all() to deal with the new
cache layout (including multiple ways), which also has been reported as
working for 7750R and 7751R. In this case, I'd prefer to merge these
cleanups first and then take a look at the rest of your fixes to see
what is still relevant.