Re: [linuxsh-dev] 2.4 patch to mainline

[SUGIOKA T. <su...@it...>]

At 09:41 01/12/12 +0900, NIIBE Yutaka <gn...@m1...> wrote:
>diff -ruN3p v2.4.17-pre8/arch/sh/kernel/rtc.c linux/arch/sh/kernel/rtc.c
>--- v2.4.17-pre8/arch/sh/kernel/rtc.c	Thu Jun 28 05:55:29 2001
>+++ linux/arch/sh/kernel/rtc.c	Wed Dec 12 09:17:30 2001
>@@ -61,6 +61,11 @@ void sh_rtc_gettimeofday(struct timeval 
> 	BCD_TO_BIN(min);
> 	BCD_TO_BIN(sec);
> 
>+#if RTC_BIT_INVERTED != 0
>+	if ((sec128 & RTC_BIT_INVERTED))
>+		sec--;
>+#endif
>+
> 	if (yr > 99 || mon < 1 || mon > 12 || day > 31 || day < 1 ||
> 	    hr > 23 || min > 59 || sec > 59) {
> 		printk(KERN_ERR

If 'sec' is chenged from 0 -> 0xffffffff then RTC will reset here.
That is bad.

My original patch seems correct at this point.


----
SUGIOKA Toshinobu