From: David W. <dw...@in...> - 2001-12-05 23:08:12
|
rm...@te... said: > I think the above is certainly better than having the ifdefs in the > code itself. I disagree. Having a flush_cache_range() function which does _less_ than its name implies is a correctness problem. Having the per-arch ifdefs to optimise away the flushes which aren't necessary, ugly though it may be, it still better than that. Provide a new function with a name that at least vaguely describes its behaviour - and all will be well. > Nonetheless, we need documentation. Even more important, the cml2 > package is not synced to SH at all. Ie, it won't work. We need to > fix that (or not use cml2 <grin>). Surely we just need to make sure that our stuff is merged first? Then paint it pink :) -- dwmw2 |