From: Robert L. <rm...@te...> - 2001-12-05 22:59:33
|
On Wed, 2001-12-05 at 17:41, David Woodhouse wrote: > The thing that does it for me is finding crap like > #define flush_cache_range(mm, start, end) do { } while (0) > > I tried to _use_ that for dealing with flash chip state changes - and it's > hardly surprising it didn't work, is it? :) I think the above is certainly better than having the ifdefs in the code itself. > Actually, it's not that hairy. I've made such a patch already, for building > the Red Hat RPM kernel for SH. It's quite clean. Ah, good. I'd like to see a merge with 2.4/2.5 mainstream, but I'd like the maintainer's permission to start pushing bits. > That is not an acceptable policy change. It will only go in if ESR sneaks it > in as part of the switch to the CML2 mechanism. If it's submitted > separately and honestly, so that it can be discussed individually, I'm sure > it won't get accepted. Good, I agree. I've said as much in the past, at least, about cml2. Nonetheless, we need documentation. Even more important, the cml2 package is not synced to SH at all. Ie, it won't work. We need to fix that (or not use cml2 <grin>). Robert Love |