Re: [linuxsh-dev] Drop-In tree updates

[David W. <dw...@in...>]

rm...@te... said:
>  I think the #if !defined(CONFIG_SH) is still enough to show a rewrite
> is needed.

The thing that does it for me is finding crap like
#define flush_cache_range(mm, start, end)	do { } while (0)

I tried to _use_ that for dealing with flash chip state changes - and it's 
hardly surprising it didn't work, is it? :)

rm...@te... said:
> I would be happy to put together a diff against the latest 2.4 and 2.5
> and send it off to Marcelo and Linus for merging into their tree.  I
> suspect it will take some work to make sure we keep the code correct
> (ie, nothing like the #if 0 stuff). 

Actually, it's not that hairy. I've made such a patch already, for building 
the Red Hat RPM kernel for SH. It's quite clean.

>   Also, SH items in Configure.help are very lacking.  CML2 will _not_
> allow an item to be selected if in non-expert mode if it has no
> configure help!

That is not an acceptable policy change. It will only go in if ESR sneaks it
in as part of the switch to the CML2 mechanism. If it's submitted 
separately and honestly, so that it can be discussed individually, I'm sure 
it won't get accepted.

But we ought to make the help text catch up anyway.

--
dwmw2