[linuxsh-dev] Re: [linux-sh:01947] Re: SH-3 MMU Bug

[M. R. B. <mr...@0x...>]

* ebihara <ebi...@si...> on Sat, Sep 22, 2001:

> 
> Please commit your nice work.
> 
> 
> diff -urN kernel/arch/sh/config.in kernel.tmp/arch/sh/config.in
> --- kernel/arch/sh/config.in	Sat Sep 22 18:54:11 2001
> +++ kernel.tmp/arch/sh/config.in	Sat Sep 22 19:34:24 2001
> @@ -115,6 +115,9 @@
>     hex 'Physical memory start address' CONFIG_MEMORY_START 08000000
>     hex 'Physical memory size' CONFIG_MEMORY_SIZE 00400000
>  fi
> +if [ "$CONFIG_CPU_SH3" = "y" ]; then
> +   bool "SH3 mmu sharedbit bug workaround" CONFIG_SH_SH3_MMU_BUG_WORKAROUND
> +fi
>  endmenu
>  

Hmm, if this is a bug across all SH3's, then why is a config option
required?  The port distinguishes across chip numbers, so if anything, if
it's localized to say, the SH7709, then you should workaround that, but
don't add a new config option for something so trivial.

M. R.