[linuxsh-dev] [PATCH] Makefile Cross Compile Sanity Check

[Paul M. <pm...@MV...>]

Hello,

Maybe it's just me, but I can't think of any good reason why arch/sh/Makefi=
le
should be overriding the toplevel CROSS_COMPILE outright if it's already be=
en
set..

The attached patch will only have $(tool-prefix) assigned in the event that
CROSS_COMPILE hasn't already been set in the toplevel Makefile.

Regards,

--=20
Paul Mundt <pm...@mv...>
MontaVista Software, Inc.

Index: ChangeLog
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/linuxsh/kernel/ChangeLog,v
retrieving revision 1.343
diff -u -r1.343 ChangeLog
--- ChangeLog	2001/09/15 04:41:45	1.343
+++ ChangeLog	2001/09/15 20:50:29
@@ -1,3 +1,8 @@
+2001-09-15  Paul Mundt  <le...@ch...>
+
+	* arch/sh/Makefile: Add check to see if CROSS_COMPILE has been
+	set before overriding it.
+=09
 2001-09-13  NIIBE Yutaka  <gn...@m1...>
=20
 	* arch/sh/kernel/sys_sh.c (arch_get_unmapped_area): Don't
Index: arch/sh/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/linuxsh/kernel/arch/sh/Makefile,v
retrieving revision 1.20
diff -u -r1.20 Makefile
--- arch/sh/Makefile	2001/07/28 04:02:00	1.20
+++ arch/sh/Makefile	2001/09/15 20:50:47
@@ -29,9 +29,9 @@
 LDFLAGS		:=3D -EB
 endif
=20
-# ifdef CONFIG_CROSSCOMPILE
+ifndef CROSS_COMPILE
 CROSS_COMPILE  =3D $(tool_prefix)
-# endif
+endif
=20
 LD	=3D$(CROSS_COMPILE)ld $(LDFLAGS)
 OBJCOPY=3D$(CROSS_COMPILE)objcopy -O binary -R .note -R .comment -R .stab =
-R .stabstr -S